Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: test/cctest/test-compiler.cc

Issue 1370303004: Distinction between FeedbackVectorICSlot and FeedbackVectorSlot eliminated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed release builds Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | test/cctest/test-feedback-vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index e35b430555187f59af58995f428a0de16a8579ed..6f8af3b3dd5cef94330480c5807be8e34ef4d8fd 100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -309,11 +309,8 @@ TEST(FeedbackVectorPreservedAcrossRecompiles) {
Handle<TypeFeedbackVector> feedback_vector(f->shared()->feedback_vector());
// Verify that we gathered feedback.
- int expected_slots = 0;
- int expected_ic_slots = 1;
- CHECK_EQ(expected_slots, feedback_vector->Slots());
- CHECK_EQ(expected_ic_slots, feedback_vector->ICSlots());
- FeedbackVectorICSlot slot_for_a(0);
+ CHECK(!feedback_vector->is_empty());
+ FeedbackVectorSlot slot_for_a(0);
Object* object = feedback_vector->Get(slot_for_a);
CHECK(object->IsWeakCell() &&
WeakCell::cast(object)->value()->IsJSFunction());
@@ -354,17 +351,13 @@ TEST(FeedbackVectorUnaffectedByScopeChanges) {
// Not compiled, and so no feedback vector allocated yet.
CHECK(!f->shared()->is_compiled());
- CHECK_EQ(0, f->shared()->feedback_vector()->Slots());
- CHECK_EQ(0, f->shared()->feedback_vector()->ICSlots());
+ CHECK(f->shared()->feedback_vector()->is_empty());
CompileRun("morphing_call();");
// Now a feedback vector is allocated.
CHECK(f->shared()->is_compiled());
- int expected_slots = 0;
- int expected_ic_slots = 2;
- CHECK_EQ(expected_slots, f->shared()->feedback_vector()->Slots());
- CHECK_EQ(expected_ic_slots, f->shared()->feedback_vector()->ICSlots());
+ CHECK(!f->shared()->feedback_vector()->is_empty());
}
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | test/cctest/test-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698