Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/ic/ia32/ic-ia32.cc

Issue 1370303004: Distinction between FeedbackVectorICSlot and FeedbackVectorSlot eliminated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed release builds Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 __ mov(ebx, FieldOperand(receiver, JSObject::kPropertiesOffset)); 334 __ mov(ebx, FieldOperand(receiver, JSObject::kPropertiesOffset));
335 __ cmp(FieldOperand(ebx, HeapObject::kMapOffset), 335 __ cmp(FieldOperand(ebx, HeapObject::kMapOffset),
336 Immediate(isolate->factory()->hash_table_map())); 336 Immediate(isolate->factory()->hash_table_map()));
337 __ j(equal, &probe_dictionary); 337 __ j(equal, &probe_dictionary);
338 338
339 // The handlers in the stub cache expect a vector and slot. Since we won't 339 // The handlers in the stub cache expect a vector and slot. Since we won't
340 // change the IC from any downstream misses, a dummy vector can be used. 340 // change the IC from any downstream misses, a dummy vector can be used.
341 Handle<TypeFeedbackVector> dummy_vector = 341 Handle<TypeFeedbackVector> dummy_vector =
342 TypeFeedbackVector::DummyVector(isolate); 342 TypeFeedbackVector::DummyVector(isolate);
343 int slot = dummy_vector->GetIndex( 343 int slot = dummy_vector->GetIndex(
344 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot)); 344 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
345 __ push(Immediate(Smi::FromInt(slot))); 345 __ push(Immediate(Smi::FromInt(slot)));
346 __ push(Immediate(dummy_vector)); 346 __ push(Immediate(dummy_vector));
347 347
348 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 348 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
349 Code::ComputeHandlerFlags(Code::LOAD_IC)); 349 Code::ComputeHandlerFlags(Code::LOAD_IC));
350 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags, 350 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags,
351 receiver, key, ebx, edi); 351 receiver, key, ebx, edi);
352 352
353 __ pop(LoadWithVectorDescriptor::VectorRegister()); 353 __ pop(LoadWithVectorDescriptor::VectorRegister());
354 __ pop(LoadDescriptor::SlotRegister()); 354 __ pop(LoadDescriptor::SlotRegister());
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 __ movzx_b(ebx, FieldOperand(ebx, Map::kInstanceTypeOffset)); 562 __ movzx_b(ebx, FieldOperand(ebx, Map::kInstanceTypeOffset));
563 __ JumpIfNotUniqueNameInstanceType(ebx, &slow); 563 __ JumpIfNotUniqueNameInstanceType(ebx, &slow);
564 564
565 565
566 if (FLAG_vector_stores) { 566 if (FLAG_vector_stores) {
567 // The handlers in the stub cache expect a vector and slot. Since we won't 567 // The handlers in the stub cache expect a vector and slot. Since we won't
568 // change the IC from any downstream misses, a dummy vector can be used. 568 // change the IC from any downstream misses, a dummy vector can be used.
569 Handle<TypeFeedbackVector> dummy_vector = 569 Handle<TypeFeedbackVector> dummy_vector =
570 TypeFeedbackVector::DummyVector(masm->isolate()); 570 TypeFeedbackVector::DummyVector(masm->isolate());
571 int slot = dummy_vector->GetIndex( 571 int slot = dummy_vector->GetIndex(
572 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 572 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
573 __ push(Immediate(Smi::FromInt(slot))); 573 __ push(Immediate(Smi::FromInt(slot)));
574 __ push(Immediate(dummy_vector)); 574 __ push(Immediate(dummy_vector));
575 } 575 }
576 576
577 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 577 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
578 Code::ComputeHandlerFlags(Code::STORE_IC)); 578 Code::ComputeHandlerFlags(Code::STORE_IC));
579 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags, 579 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
580 receiver, key, edi, no_reg); 580 receiver, key, edi, no_reg);
581 581
582 if (FLAG_vector_stores) { 582 if (FLAG_vector_stores) {
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
902 Condition cc = 902 Condition cc =
903 (check == ENABLE_INLINED_SMI_CHECK) 903 (check == ENABLE_INLINED_SMI_CHECK)
904 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 904 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
905 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 905 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
906 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 906 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
907 } 907 }
908 } // namespace internal 908 } // namespace internal
909 } // namespace v8 909 } // namespace v8
910 910
911 #endif // V8_TARGET_ARCH_IA32 911 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698