Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/ic/arm64/ic-arm64.cc

Issue 1370303004: Distinction between FeedbackVectorICSlot and FeedbackVectorSlot eliminated. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed release builds Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 __ JumpIfRoot(scratch3, Heap::kHashTableMapRootIndex, &probe_dictionary); 403 __ JumpIfRoot(scratch3, Heap::kHashTableMapRootIndex, &probe_dictionary);
404 404
405 // The handlers in the stub cache expect a vector and slot. Since we won't 405 // The handlers in the stub cache expect a vector and slot. Since we won't
406 // change the IC from any downstream misses, a dummy vector can be used. 406 // change the IC from any downstream misses, a dummy vector can be used.
407 Register vector = LoadWithVectorDescriptor::VectorRegister(); 407 Register vector = LoadWithVectorDescriptor::VectorRegister();
408 Register slot = LoadWithVectorDescriptor::SlotRegister(); 408 Register slot = LoadWithVectorDescriptor::SlotRegister();
409 DCHECK(!AreAliased(vector, slot, scratch1, scratch2, scratch3, scratch4)); 409 DCHECK(!AreAliased(vector, slot, scratch1, scratch2, scratch3, scratch4));
410 Handle<TypeFeedbackVector> dummy_vector = 410 Handle<TypeFeedbackVector> dummy_vector =
411 TypeFeedbackVector::DummyVector(masm->isolate()); 411 TypeFeedbackVector::DummyVector(masm->isolate());
412 int slot_index = dummy_vector->GetIndex( 412 int slot_index = dummy_vector->GetIndex(
413 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot)); 413 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
414 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 414 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
415 __ Mov(slot, Operand(Smi::FromInt(slot_index))); 415 __ Mov(slot, Operand(Smi::FromInt(slot_index)));
416 416
417 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 417 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
418 Code::ComputeHandlerFlags(Code::LOAD_IC)); 418 Code::ComputeHandlerFlags(Code::LOAD_IC));
419 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags, 419 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags,
420 receiver, key, scratch1, 420 receiver, key, scratch1,
421 scratch2, scratch3, scratch4); 421 scratch2, scratch3, scratch4);
422 // Cache miss. 422 // Cache miss.
423 KeyedLoadIC::GenerateMiss(masm); 423 KeyedLoadIC::GenerateMiss(masm);
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 693
694 if (FLAG_vector_stores) { 694 if (FLAG_vector_stores) {
695 // The handlers in the stub cache expect a vector and slot. Since we won't 695 // The handlers in the stub cache expect a vector and slot. Since we won't
696 // change the IC from any downstream misses, a dummy vector can be used. 696 // change the IC from any downstream misses, a dummy vector can be used.
697 Register vector = VectorStoreICDescriptor::VectorRegister(); 697 Register vector = VectorStoreICDescriptor::VectorRegister();
698 Register slot = VectorStoreICDescriptor::SlotRegister(); 698 Register slot = VectorStoreICDescriptor::SlotRegister();
699 DCHECK(!AreAliased(vector, slot, x5, x6, x7, x8)); 699 DCHECK(!AreAliased(vector, slot, x5, x6, x7, x8));
700 Handle<TypeFeedbackVector> dummy_vector = 700 Handle<TypeFeedbackVector> dummy_vector =
701 TypeFeedbackVector::DummyVector(masm->isolate()); 701 TypeFeedbackVector::DummyVector(masm->isolate());
702 int slot_index = dummy_vector->GetIndex( 702 int slot_index = dummy_vector->GetIndex(
703 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 703 FeedbackVectorSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
704 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 704 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
705 __ Mov(slot, Operand(Smi::FromInt(slot_index))); 705 __ Mov(slot, Operand(Smi::FromInt(slot_index)));
706 } 706 }
707 707
708 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 708 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
709 Code::ComputeHandlerFlags(Code::STORE_IC)); 709 Code::ComputeHandlerFlags(Code::STORE_IC));
710 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags, 710 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
711 receiver, key, x5, x6, x7, x8); 711 receiver, key, x5, x6, x7, x8);
712 // Cache miss. 712 // Cache miss.
713 __ B(&miss); 713 __ B(&miss);
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 } else { 890 } else {
891 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ); 891 DCHECK(to_patch->Mask(TestBranchMask) == TBNZ);
892 // This is JumpIfSmi(smi_reg, branch_imm). 892 // This is JumpIfSmi(smi_reg, branch_imm).
893 patcher.tbz(smi_reg, 0, branch_imm); 893 patcher.tbz(smi_reg, 0, branch_imm);
894 } 894 }
895 } 895 }
896 } // namespace internal 896 } // namespace internal
897 } // namespace v8 897 } // namespace v8
898 898
899 #endif // V8_TARGET_ARCH_ARM64 899 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/ic/arm/ic-arm.cc ('k') | src/ic/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698