Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: tools/gn/builder.cc

Issue 1370293002: GN comment spelling fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/gn/builder.h" 5 #include "tools/gn/builder.h"
6 6
7 #include "tools/gn/config.h" 7 #include "tools/gn/config.h"
8 #include "tools/gn/deps_iterator.h" 8 #include "tools/gn/deps_iterator.h"
9 #include "tools/gn/err.h" 9 #include "tools/gn/err.h"
10 #include "tools/gn/loader.h" 10 #include "tools/gn/loader.h"
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 235
236 return true; 236 return true;
237 } 237 }
238 238
239 bool Builder::ConfigDefined(BuilderRecord* record, Err* err) { 239 bool Builder::ConfigDefined(BuilderRecord* record, Err* err) {
240 Config* config = record->item()->AsConfig(); 240 Config* config = record->item()->AsConfig();
241 if (!AddDeps(record, config->configs(), err)) 241 if (!AddDeps(record, config->configs(), err))
242 return false; 242 return false;
243 243
244 // Make sure all deps of this config are scheduled to be loaded. For other 244 // Make sure all deps of this config are scheduled to be loaded. For other
245 // item types like targets, the "should generate" flag is propogated around 245 // item types like targets, the "should generate" flag is propagated around
246 // to mark whether this should happen. We could call 246 // to mark whether this should happen. We could call
247 // RecursiveSetShouldGenerate to do this step here, but since configs nor 247 // RecursiveSetShouldGenerate to do this step here, but since configs nor
248 // anything they depend on is actually written, the "generate" flag isn't 248 // anything they depend on is actually written, the "generate" flag isn't
249 // relevant and means extra book keeping. Just force load any deps of this 249 // relevant and means extra book keeping. Just force load any deps of this
250 // config. 250 // config.
251 for (const auto& cur : record->all_deps()) 251 for (const auto& cur : record->all_deps())
252 ScheduleItemLoadIfNecessary(cur); 252 ScheduleItemLoadIfNecessary(cur);
253 253
254 return true; 254 return true;
255 } 255 }
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 std::string ret; 535 std::string ret;
536 for (size_t i = 0; i < cycle.size(); i++) { 536 for (size_t i = 0; i < cycle.size(); i++) {
537 ret += " " + cycle[i]->label().GetUserVisibleName(false); 537 ret += " " + cycle[i]->label().GetUserVisibleName(false);
538 if (i != cycle.size() - 1) 538 if (i != cycle.size() - 1)
539 ret += " ->"; 539 ret += " ->";
540 ret += "\n"; 540 ret += "\n";
541 } 541 }
542 542
543 return ret; 543 return ret;
544 } 544 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698