[Chromoting] Remote Assistance in Public Session.

[Chromoting] Remote Assistance in Public Session.

This CL provides remote assistance in Public Session.
Summary of changes:
1. Move the remoting.testEvents initialization to ui_mode.js
   as it is only referenced there.
2. Create a separate page public_session.html that contains the
   main ui for public session.
3. Use the service account email address to infer whether we
   are currently in a public session.
4. Decouple remoting.HostController from host_screen.js
   Previously, remoting.HostController is used to retrieve the
   host version, which is problematic as that refers to the me2me
   host version as opposed to the it2me host version.

BUG=508608
Committed: https://crrev.com/08d28524dc2673bc7e85b37d2b82d0d65c34ea05
Cr-Commit-Position: refs/heads/master@{#351861}

[kelvinp, 2015-09-30 01:04:46]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-09-30 01:05:39]

PTAL

[Jamie, 2015-09-30 17:46:13]

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/htm...
File remoting/webapp/crd/html/public_session.css (right):

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/htm...
remoting/webapp/crd/html/public_session.css:9: box-shadow: none;
The intent here is to override the definition in main.css, correct? In that
case, I would prefer you do something to make the selector more specific, rather
than relying on the include order. I think !important is acceptable here, or if
the dialog has an id you could reference that explicitly.

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/activation_handler.js (right):

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/activation_handler.js:161: if
(email.indexOf('@gserviceaccount.com') == -1) {
Please add a TODO to clean this up once we have an API (you may be able to
de-Promisify it at that point).

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/activation_handler.js:171: 'height': 300,
In general, you can't hard-code a height because it will be too small for some
languages and too large for others. I think you need to call resizeToContent
instead, probably each time the DOM changes.

[kelvinp, 2015-09-30 19:35:47]

PTAL

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/htm...
File remoting/webapp/crd/html/public_session.css (right):

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/htm...
remoting/webapp/crd/html/public_session.css:9: box-shadow: none;
On 2015/09/30 17:46:13, Jamie wrote:
> The intent here is to override the definition in main.css, correct? In that
> case, I would prefer you do something to make the selector more specific,
rather
> than relying on the include order. I think !important is acceptable here, or
if
> the dialog has an id you could reference that explicitly.

Done.

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/activation_handler.js (right):

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/activation_handler.js:161: if
(email.indexOf('@gserviceaccount.com') == -1) {
On 2015/09/30 17:46:13, Jamie wrote:
> Please add a TODO to clean this up once we have an API (you may be able to
> de-Promisify it at that point).

Fixed to use the actual flag instead.

https://codereview.chromium.org/1370283004/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/activation_handler.js:171: 'height': 300,
On 2015/09/30 17:46:13, Jamie wrote:
> In general, you can't hard-code a height because it will be too small for some
> languages and too large for others. I think you need to call resizeToContent
> instead, probably each time the DOM changes.

Fixed in public_session_main.js

[Jamie, 2015-09-30 20:24:09]

lgtm

https://codereview.chromium.org/1370283004/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/activation_handler.js (right):

https://codereview.chromium.org/1370283004/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/activation_handler.js:103: this.launchPublicSession_();
We're not really launching a public session; we're launching an auto-shared
IT2Me session. I think the name of this method should reflect what it does, not
the circumstances under which it's called.

Similarly, you might want to consider renaming createWindow_, since it's no
longer very descriptive.

Perhaps launchFullUi and launchIt2MeUi?

https://codereview.chromium.org/1370283004/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/public_session_main.js (right):

https://codereview.chromium.org/1370283004/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/public_session_main.js:24: };
This would be cleaner hooking the uiModeChanged event. However, right now that's
in a namespace called testEvents, which suggests it's not used by production
code so changing it would involve a lot of churn. If you prefer, you can fix in
a follow-up CL.

[kelvinp, 2015-09-30 23:13:49]

FYI

https://chromiumcodereview.appspot.com/1370283004/diff/40001/remoting/webapp/...
File remoting/webapp/crd/js/activation_handler.js (right):

https://chromiumcodereview.appspot.com/1370283004/diff/40001/remoting/webapp/...
remoting/webapp/crd/js/activation_handler.js:103: this.launchPublicSession_();
On 2015/09/30 20:24:09, Jamie wrote:
> We're not really launching a public session; we're launching an auto-shared
> IT2Me session. I think the name of this method should reflect what it does,
not
> the circumstances under which it's called.
> 
> Similarly, you might want to consider renaming createWindow_, since it's no
> longer very descriptive.
> 
> Perhaps launchFullUi and launchIt2MeUi?

Done.

https://chromiumcodereview.appspot.com/1370283004/diff/40001/remoting/webapp/...
File remoting/webapp/crd/js/public_session_main.js (right):

https://chromiumcodereview.appspot.com/1370283004/diff/40001/remoting/webapp/...
remoting/webapp/crd/js/public_session_main.js:24: };
On 2015/09/30 20:24:09, Jamie wrote:
> This would be cleaner hooking the uiModeChanged event. However, right now
that's
> in a namespace called testEvents, which suggests it's not used by production
> code so changing it would involve a lot of churn. If you prefer, you can fix
in
> a follow-up CL.

Agree. I will fix that in a separate CL.

[kelvinp, 2015-09-30 23:14:29]

The CQ bit was checked by kelvinp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-30 23:15:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370283004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370283004/60001

[commit-bot: I haz the power, 2015-09-30 23:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 23:59:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kelvinp, 2015-10-01 00:00:01]

The CQ bit was unchecked by kelvinp@chromium.org

[kelvinp, 2015-10-01 01:29:54]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-10-01 01:29:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1370283004/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-01 01:31:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370283004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370283004/80001

[commit-bot: I haz the power, 2015-10-01 01:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 01:35:18]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kelvinp, 2015-10-01 18:22:36]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-10-01 18:22:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1370283004/#ps100001 (title: "Rebase")

[commit-bot: I haz the power, 2015-10-01 18:24:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370283004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370283004/100001

[commit-bot: I haz the power, 2015-10-01 19:16:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-01 19:18:06]

Patchset 6 (id:??) landed as
https://crrev.com/08d28524dc2673bc7e85b37d2b82d0d65c34ea05
Cr-Commit-Position: refs/heads/master@{#351861}