Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1370283003: X87: [es6] Fix invalid ToString in implementation of ToName. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Fix invalid ToString in implementation of ToName. port 09626525fea63396c8a200deb9081d6dd1034d57 (r30957). original commit message: BUG= Committed: https://crrev.com/22a38d725256e9045987454c0c2086c9c1086b04 Cr-Commit-Position: refs/heads/master@{#30988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 2 months ago (2015-09-29 01:40:18 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-09-29 01:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370283003/1
5 years, 2 months ago (2015-09-29 01:58:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 02:20:56 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 02:21:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a38d725256e9045987454c0c2086c9c1086b04
Cr-Commit-Position: refs/heads/master@{#30988}

Powered by Google App Engine
This is Rietveld 408576698