Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1370263004: CMake for Windows (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
Marco A.
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake for Windows Except for some small edits, this is mainly: patch from issue 1353953004 at patchset 80001 (http://crrev.com/1353953004#ps80001) CMake configuration file for compiling Windows x64 VS2013 with CMake. Things to be fixed: - only x64 is supported - I didn't try SKIA_GDI (experimental) and directly went for the DirectWrite - this should need an option in the CMake configuration - make sure yasm and custom build rules paths are set correctly - if the hierarchy changes CMake will just blow things up - compilation works but there are LOTS and LOTS of warnings (over 9000), if this is okay nevermind but since most of them are related to deprecated functions either consider fixing or suppressing them - Release mode is untested - I suppose it won't be a big deal but might need some fixing More info here: https://groups.google.com/forum/#!topic/skia-discuss/HLu-Hesfbg4 BUG=skia:4269 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/56c6a117b222aa7d94843cfe6058e085d4394d97

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M cmake/CMakeLists.txt View 1 5 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370263004/20001
5 years, 2 months ago (2015-09-30 17:40:21 UTC) #2
mtklein_C
Sorry to jump you around one last time. I saw a few things that needed ...
5 years, 2 months ago (2015-09-30 17:43:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 17:47:27 UTC) #6
Marco A.
On 2015/09/30 17:43:41, mtklein_C wrote: > Sorry to jump you around one last time. I ...
5 years, 2 months ago (2015-09-30 17:56:06 UTC) #7
mtklein_C
> lgtm (I don't get the money technically, but that's a detail :P) Oh, goodness, ...
5 years, 2 months ago (2015-09-30 18:00:16 UTC) #8
mtklein_C
Ah, well then in that case, here we go!
5 years, 2 months ago (2015-09-30 18:06:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370263004/20001
5 years, 2 months ago (2015-09-30 18:06:22 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 18:06:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/56c6a117b222aa7d94843cfe6058e085d4394d97

Powered by Google App Engine
This is Rietveld 408576698