Add support for Tegra V4L2 VDA

content/common/gpu/media/v4l2_video_device.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the V4L2Device interface which is used by the
 // V4L2DecodeAccelerator class to delegate/pass the device specific
 // handling of any of the functionalities.
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_
 #define CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_
 
+#include "ui/gl/gl_bindings.h"
+
 namespace content {
 
 class V4L2Device {
  public:
   V4L2Device();
   virtual ~V4L2Device();
 
   // Tries to create and initialize an appropriate V4L2Device object for the
   // current platform and returns a scoped_ptr<V4L2Device> on success else
   // returns NULL.
-  static scoped_ptr<V4L2Device> Create();
+  static scoped_ptr<V4L2Device> Create(EGLContext egl_context);
 
   // Parameters and return value are the same as for the standard ioctl() system
   // call.
   virtual int Ioctl(int request, void* arg) = 0;
 
   // This method sleeps until either:
   // - SetDevicePollInterrupt() is called (on another thread),
   // - |poll_device| is true, and there is new data to be read from the device,
   //   or an event from the device has arrived; in the latter case
   //   |*event_pending| will be set to true.
@@ skipping 10 matching lines @@
   virtual bool SetDevicePollInterrupt() = 0;
   virtual bool ClearDevicePollInterrupt() = 0;
 
   // Wrappers for standard mmap/munmap system calls.
   virtual void* Mmap(void* addr,
                      unsigned int len,
                      int prot,
                      int flags,
                      unsigned int offset) = 0;
   virtual void Munmap(void* addr, unsigned int len) = 0;
+
+  virtual EGLImageKHR CreateEGLImage(EGLDisplay egl_display,

[Ami GONE FROM CHROMIUM, 2014/02/07 09:09:30]

Need to document these methods & parameters.
I'm especially unclear at this point in the review what |buffer_index| is
supposed to be (I see how it's used, but I don't understand what it means in the
context of a generic V4L2Device).

[shivdasp, 2014/02/10 13:31:17]

This method exists because of the difference in how Exynos and Tegra create the
EglImages. See previous comments.

On 2014/02/07 09:09:30, Ami Fischman wrote:

+                                     EGLint attrib[],
+                                     unsigned int texture_id,
+                                     unsigned int buffer_index) = 0;
+
+  virtual unsigned int GetTextureTarget() = 0;
 };
 }  //  namespace content
 
 #endif  //  CONTENT_COMMON_GPU_MEDIA_V4L2_VIDEO_DEVICE_H_