Add support for Tegra V4L2 VDA

content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.h"
 
 #include <dlfcn.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/socket.h>
@@ skipping 204 matching lines @@
   // Preload the Mali library.
   dlopen("/usr/lib/libmali.so", dlopen_flag);
 
   // Preload the Tegra libraries.
   dlopen("/usr/lib/libnvrm.so", dlopen_flag);
   dlopen("/usr/lib/libnvrm_graphics.so", dlopen_flag);
   dlopen("/usr/lib/libnvidia-glsi.so", dlopen_flag);
   dlopen("/usr/lib/libnvidia-rmapi-tegra.so", dlopen_flag);
   dlopen("/usr/lib/libnvidia-eglcore.so", dlopen_flag);
   // TODO(davidung): remove these libraries before nyan launch.
+  dlopen("/usr/lib/libtegrav4l2.so", dlopen_flag);

[Jorge Lucangeli Obes, 2014/03/25 21:15:14]

Is this really needed?

[shivdasp, 2014/03/26 02:54:25]

Yes this is needed for the video decode acceleration on Tegra.
On 2014/03/25 21:15:14, Jorge Lucangeli Obes wrote:

[Jorge Lucangeli Obes, 2014/03/26 03:15:48]

I apologize, I wasn't clear. I meant "is this needed here in the sandbox
whitelist". If David managed to preload *all* the other Nvidia .so's in his CL,
I'm surprised this one cannot be preloaded before enabling the sandbox.

[shivdasp, 2014/03/26 03:34:29]

I get your point.
I think all the libraries that David's CL preloaded were part of graphics stack
which got loaded through some gl initialization.
We need this lib loaded here here since it is not part of graphics stack and is
a wrapper for MM stack.

On 2014/03/26 03:15:48, Jorge Lucangeli Obes wrote:

[Jorge Lucangeli Obes, 2014/03/26 16:47:24]

Thanks for the explanation. Then my only suggestion would be to check that video
decode still works after David's change (not just that the change still applies,
but that functionality works).

[shivdasp, 2014/03/26 21:30:52]

Yes I have tested with David's change too.
Nevertheless I will have to rebase once his change lands so it will get tested
once more.
Thanks.

+  // Resetting errno since platform-specific libraries will fail on other
+  // platforms.
+  errno = 0;
 
   return true;
 }
 
 }  // namespace content