Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 137023003: Remove third_party\python_26. (Closed)

Created:
6 years, 11 months ago by M-A Ruel
Modified:
6 years, 11 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Remove third_party\python_26. The last user was ChromeFrame (recently removed) and pyauto. I do not believe pyauto_functional.py is still used. R=thakis@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244676

Patch Set 1 #

Patch Set 2 : Revert .gitmodules, otherwise try jobs fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/functional/pyauto_functional.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/licenses.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
M-A Ruel
6 years, 11 months ago (2014-01-13 19:14:44 UTC) #1
M-A Ruel
6 years, 11 months ago (2014-01-13 19:14:46 UTC) #2
Nico
lgtm, good luck. Ping sheriffs / trooper before landing.
6 years, 11 months ago (2014-01-13 19:19:08 UTC) #3
M-A Ruel
On 2014/01/13 19:19:08, Nico wrote: > lgtm, good luck. Ping sheriffs / trooper before landing. ...
6 years, 11 months ago (2014-01-14 00:19:55 UTC) #4
M-A Ruel
Committed patchset #2 manually as r244676 (presubmit successful).
6 years, 11 months ago (2014-01-14 13:38:25 UTC) #5
Reid Kleckner
This broke running gyp_chromium on Cygwin. See this code: https://code.google.com/p/chromium/codesearch#chromium/src/build/gyp_chromium&q=gyp_chromium&sq=package:chromium&type=cs&l=276 Will Chromium continue to ship ...
6 years, 11 months ago (2014-01-15 02:20:28 UTC) #6
M-A Ruel
On 2014/01/15 02:20:28, Reid Kleckner wrote: > This broke running gyp_chromium on Cygwin. See this ...
6 years, 11 months ago (2014-01-15 02:59:13 UTC) #7
Reid Kleckner (google)
On Tue, Jan 14, 2014 at 6:59 PM, <maruel@chromium.org> wrote: > On 2014/01/15 02:20:28, Reid ...
6 years, 11 months ago (2014-01-15 03:32:28 UTC) #8
M-A Ruel
On 2014/01/15 03:32:28, Reid Kleckner (google) wrote: > I think the best thing would be ...
6 years, 11 months ago (2014-01-15 14:30:22 UTC) #9
Reid Kleckner (google)
6 years, 11 months ago (2014-01-15 17:32:01 UTC) #10
On Wed, Jan 15, 2014 at 6:30 AM, <maruel@chromium.org> wrote:

> On 2014/01/15 03:32:28, Reid Kleckner (google) wrote:
>
>> I think the best thing would be for depot_tools/python to become the
>> single, hermetic win32 python used everywhere.  When I twiddle my PATH to
>> point at a win32 python and gclient sync, I get the error:
>> download_from_google_storage --no_resume --platform=win32 --no_auth
>> --bucket chromium-gn -s src/tools/gn/bin/win/gn.exe.sha1
>> C:\python_27\files\python.exe: can't open file
>> '/src/depot_tools/download_from_google_storage.py': [Errno 2] No such
>> file
>> or directory
>>
>
>  So we're already assuming it.  update_depot_tools.bat should probably just
>> fetch it unconditionally.
>>
>
> So you volunteer to do it?
>

I'm happy to hack some shell scripts until it works for me, but I don't
want to become the expert and maintainer for it.  =/

Maybe we should do a survey and see how many Chromium devs use Cygwin.  If
it's < 4, Chromium should probably drop support for this configuration and
remove it from the docs.


> I'm fine with you reverting this CL to unblock all cygwin users, but keep
> in
> mind you open yourself to being broken again once someone checks in 2.7
> only
> python code.
>

That doesn't seem worth it.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698