Issue 1370203007: Revert of Oilpan: fix build after r352251.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370203007: Revert of Oilpan: fix build after r352251. (Closed)

Created:
5 years, 2 months ago by yosin_UTC9

Modified:
5 years, 2 months ago

Reviewers:
oilpan-reviews, haraken, sof

CC:
blink-reviews, asanka, benjhayden+dwatch_chromium.org, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Oilpan: fix build after r352251. (patchset #1 id:1 of https://codereview.chromium.org/1387773002/ ) Reason for revert: For reverting http://crrev.com/1381693002 Original issue's description: > Oilpan: fix build after r352251. > > TBR=oilpan-reviews > BUG=495801 > > Committed: https://crrev.com/a0016b20f1a6531528c101888c4c681f0e05abdc > Cr-Commit-Position: refs/heads/master@{#352272} TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495801 Committed: https://crrev.com/10ff10b620b8656c09e5948f2bf44133d5e80b6c Cr-Commit-Position: refs/heads/master@{#352288}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -24 lines)			Patch
	M	third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
	M	third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp	View		1 chunk	+11 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370203007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370203007/1

5 years, 2 months ago (2015-10-05 04:14:25 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-05 04:16:00 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/10ff10b620b8656c09e5948f2bf44133d5e80b6c
Cr-Commit-Position: refs/heads/master@{#352288}

Expand Messages | Collapse Messages