Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1370203005: Fix line break opportunities between HYPHEN-MINUS and closing punctuation (Closed)

Created:
5 years, 2 months ago by kojii
Modified:
5 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix line break opportunities between HYPHEN-MINUS and closing punctuation This patch fixes not to break between HYPHEN-MINUS and closing punctuation characters by following UAX#14 LB13[1]. U+002D HYPHEN-MINUS: * wkb.ug/37698 changed to allow break after it all the time. * wkb.ug/20677 fixed HYPHEN-MINUS + DIGIT/PERIOD not to break. This leaves the break opportunities before closing punctuation characters such as ")". UAX#14 LB13[1] defines character classes not to break before. Adding this rule matches the behavior for these characters to IE11. [1] http://unicode.org/reports/tr14/#LB13 BUG=531409 Committed: https://crrev.com/40da64cedd00110bbfa39449ce72b777d930b001 Cr-Commit-Position: refs/heads/master@{#351806}

Patch Set 1 : Test and result before patch #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/text/line-break-ascii.html View 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/line-break-ascii-expected.txt View 1 1 chunk +96 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextBreakIterator.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kojii
PTAL.
5 years, 2 months ago (2015-10-01 09:37:00 UTC) #2
eae
LGTM
5 years, 2 months ago (2015-10-01 14:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370203005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370203005/20001
5 years, 2 months ago (2015-10-01 15:04:40 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 15:13:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 15:14:21 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40da64cedd00110bbfa39449ce72b777d930b001
Cr-Commit-Position: refs/heads/master@{#351806}

Powered by Google App Engine
This is Rietveld 408576698