Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1370203002: Revert of Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:80001 of https://codereview.chromium.org/1361763004/ ) Reason for revert: This CL breaks cross-compiling to arm. Original issue's description: > Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > Committed: https://crrev.com/0b48b2a8ebfc791a36f4ec1f299f46db76265a3a > Cr-Commit-Position: refs/heads/master@{#30977} TBR=jochen@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4d03c3aabad6517ff058124bb799ca6a4156e570 Cr-Commit-Position: refs/heads/master@{#30982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M include/v8config.h View 6 chunks +0 lines, -17 lines 0 comments Download
M src/base/logging.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/base/platform/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
Created Revert of Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy ...
5 years, 2 months ago (2015-09-28 16:40:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370203002/1
5 years, 2 months ago (2015-09-28 16:40:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:41:00 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:47:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d03c3aabad6517ff058124bb799ca6a4156e570
Cr-Commit-Position: refs/heads/master@{#30982}

Powered by Google App Engine
This is Rietveld 408576698