Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1370193002: scheduler: Disable per-frame timer scheduling (Closed)

Created:
5 years, 2 months ago by Sami
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Disable per-frame timer scheduling Disable per-frame timer scheduling for now since it is causing crashes in situations where the underlying timer task runner becomes null. BUG=536656, 510398 Committed: https://crrev.com/936d50e735f683407b3fe5cee3de43d2a0fc0045 Cr-Commit-Position: refs/heads/master@{#351096}

Patch Set 1 #

Patch Set 2 : Disable the same override in LocalDOMWindow too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M third_party/WebKit/Source/core/frame/DOMTimer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sami
5 years, 2 months ago (2015-09-28 16:38:50 UTC) #2
alex clarke (OOO till 29th)
lgtm
5 years, 2 months ago (2015-09-28 16:44:32 UTC) #3
Rick Byers
RS LGTM
5 years, 2 months ago (2015-09-28 16:48:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370193002/20001
5 years, 2 months ago (2015-09-28 16:50:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 19:16:49 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:17:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/936d50e735f683407b3fe5cee3de43d2a0fc0045
Cr-Commit-Position: refs/heads/master@{#351096}

Powered by Google App Engine
This is Rietveld 408576698