Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1370143007: Oilpan: fix build after r351868. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r351868. We do not have compiler support for traceable Oilpan heap references, hence undo the Member<> to ref conversion that r351868 made. TBR=oilpan-reviews BUG= NOTRY=true Committed: https://crrev.com/1c2a93f3cdcf4673299a3c6c4b6b8b79c504f088 Cr-Commit-Position: refs/heads/master@{#351887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -48 lines) Patch
M third_party/WebKit/Source/core/paint/FramePainter.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FramePainter.cpp View 5 chunks +48 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
5 years, 2 months ago (2015-10-01 21:11:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370143007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370143007/1
5 years, 2 months ago (2015-10-01 21:11:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 21:18:39 UTC) #5
Xianzhu
A question: the painters are all stack allocated temporary objects and just hold the reference ...
5 years, 2 months ago (2015-10-01 21:18:48 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c2a93f3cdcf4673299a3c6c4b6b8b79c504f088 Cr-Commit-Position: refs/heads/master@{#351887}
5 years, 2 months ago (2015-10-01 21:21:22 UTC) #7
haraken
5 years, 2 months ago (2015-10-01 23:31:33 UTC) #8
Message was sent while issue was closed.
LGTM

On 2015/10/01 21:18:48, Xianzhu wrote:
> A question: the painters are all stack allocated temporary objects and just
hold
> the reference during a method call like the following:
>   FramePainter(frameView).paint();
> 
> Should this kind of reference also need Member<>?

In terms of correctness, it is okay to use a raw pointer in STACK_ALLOCATED but
we explicitly use Member<> to indicate that we took care of the pointer. (So
you're right -- a raw pointer works fine in terms of correctness.)

Powered by Google App Engine
This is Rietveld 408576698