MD Settings: Minor fixes to manage languages page

chrome/browser/resources/settings/languages_page/manage_languages_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'cr-settings-manage-languages-page' is a sub-page for enabling
  * and disabling languages.
  *
  * @group Chrome Settings Elements
  * @element cr-settings-manage-languages-page
@@ skipping 12 matching lines @@
 
     /**
      * @type {LanguagesModel|undefined}
      */
     languages: {
       type: Object,
       notify: true,
     },
 
     /**
-     * @private {Array<{code: string, displayName: string, enabled: boolean}>|
+     * @private {Array<{code: string, displayName: string,

[stevenjb, 2015/09/28 23:51:54]

!Array<!{

[michaelpg, 2015/09/29 00:20:32]

Done.

+     *                  nativeDisplayName: string, enabled: boolean}>|
      *           undefined}
      */
     availableLanguages_: Array,
   },
 
   observers: [
     'enabledLanguagesChanged_(languages.enabledLanguages.*)',
   ],
 
   /**
    * Handler for removing a language.
    * @param {!{model: !{item: !Language}}} e
    * @private
    */
   onRemoveLanguageTap_: function(e) {
     this.$.languages.disableLanguage(e.model.item.language.code);
   },
 
   /**
    * Handler for adding a language.
    * @param {!{model: {item: !chrome.languageSettingsPrivate.Language}}} e
    * @private
    */
   onAddLanguageTap_: function(e) {
     this.$.languages.enableLanguage(e.model.item.code);
   },
 
   /**
-   * True if a language is not the prospective UI language or the last remaining
-   * language.
+   * True if a language is not the current or prospective UI language.
    * @param {string} languageCode
-   * @param {!Array<!LanguageInfo>} enableLanguage
+   * @param {!Array<!LanguageInfo>} enabledLanguages
+   * @return {boolean}
    * @private
-   * @return {boolean}
    */
-  canRemoveLanguage_: function(languageCode, enabledLanguages) {
-    var appLocale = this.prefs.intl.app_locale.value || navigator.language;
-    if (languageCode == appLocale)
+  canRemoveLanguage_: function(languageCode, prospectiveUILanguage) {

[stevenjb, 2015/09/28 23:51:54]

enabledLanguages or prospective... ?

[michaelpg, 2015/09/29 00:20:32]

Done. Forgot to Closure-compile this file!

+    if (languageCode == navigator.language ||
+        languageCode == prospectiveUILanguage) {
       return false;
-    if (enabledLanguages.length == 1)
-      return false;
+    }
+    assert(this.languages.enabledLanguages.length > 1);
     return true;
   },
 
   /**
-   * Updates the available languages to be bound to the iron-list.
-   * TODO(michaelpg): Update properties of individual items instead of
-   *     rebuilding entire list.
+   * Updates the available languages that are bound to the iron-list.
    * @private
    */
   enabledLanguagesChanged_: function() {
-    var availableLanguages = [];
+    var availableLanguages = this.availableLanguages_ || [];
     for (var i = 0; i < this.languages.supportedLanguages.length; i++) {
-      var language = this.languages.supportedLanguages[i];
-      availableLanguages.push({
-        code: language.code,
-        displayName: language.displayName,
-        enabled: this.$.languages.isEnabled(language.code)
-      });
+      if (this.availableLanguages_) {
+        this.set('availableLanguages_.' + i + '.enabled',
+                 this.$.languages.isEnabled(this.availableLanguages_[i].code));

[stevenjb, 2015/09/28 23:51:54]

This is weird... if (this.availableLanguages_) then we effectively ignore the
local availableLanguages. I think the if () should be at the top level, even
though it means two for loops.

[michaelpg, 2015/09/29 00:20:32]

Done. This should make more sense. Hope you don't mind the inverted if.

+      } else {
+        var language = this.languages.supportedLanguages[i];
+        availableLanguages.push({
+          code: language.code,
+          displayName: language.displayName,
+          nativeDisplayName: language.nativeDisplayName,
+          enabled: this.$.languages.isEnabled(language.code)
+        });
+      }
     }
-    this.availableLanguages_ = availableLanguages;
+    if (!this.availableLanguages_)
+      this.availableLanguages_ = availableLanguages;
   },
 });