Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1370133004: [Android] Log once per minute while waiting for timeout_retry thread completion. (Closed)

Created:
5 years, 2 months ago by jbudorick
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Log once per minute while waiting for timeout_retry thread completion. This should prevent all commands run via timeout_retry.Run from triggering the 20-minute buildbot timeout. In particular, this should prevent long-running gtest suites, e.g. the webrtc perf tests, from timing out. BUG= Committed: https://crrev.com/8cf53d6715889128e790939ce36e827071984a40 Cr-Commit-Position: refs/heads/master@{#351112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -14 lines) Patch
M build/android/devil/android/decorators.py View 3 chunks +8 lines, -3 lines 0 comments Download
M build/android/devil/utils/reraiser_thread.py View 4 chunks +22 lines, -6 lines 0 comments Download
M build/android/devil/utils/timeout_retry.py View 4 chunks +10 lines, -4 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
5 years, 2 months ago (2015-09-28 15:53:29 UTC) #2
mikecase (-- gone --)
lgtm
5 years, 2 months ago (2015-09-28 16:33:19 UTC) #3
kjellander_chromium
lgtm Since no tests, I assume you've tested this at least once with a manual ...
5 years, 2 months ago (2015-09-28 16:41:57 UTC) #4
jbudorick
On 2015/09/28 at 16:41:57, kjellander wrote: > lgtm > > Since no tests, I assume ...
5 years, 2 months ago (2015-09-28 16:54:57 UTC) #5
jbudorick
On 2015/09/28 at 16:54:57, jbudorick wrote: > On 2015/09/28 at 16:41:57, kjellander wrote: > > ...
5 years, 2 months ago (2015-09-28 16:56:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370133004/1
5 years, 2 months ago (2015-09-28 16:56:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:30:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:32:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf53d6715889128e790939ce36e827071984a40
Cr-Commit-Position: refs/heads/master@{#351112}

Powered by Google App Engine
This is Rietveld 408576698