Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1370123002: [heap] Remove retry space from AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove retry space from AllocateRaw. BUG= Committed: https://crrev.com/2786ceec1eb491494d24d29a59eefbe3b6704be2 Cr-Commit-Position: refs/heads/master@{#30984}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -300 lines) Patch
M src/heap/heap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 26 chunks +37 lines, -90 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 4 chunks +8 lines, -14 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +0 lines, -111 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Hannes Payer (out of office)
5 years, 2 months ago (2015-09-28 15:12:09 UTC) #2
Michael Starzinger
LGTM with one comment to address. https://codereview.chromium.org/1370123002/diff/20001/src/heap/heap-inl.h File src/heap/heap-inl.h (right): https://codereview.chromium.org/1370123002/diff/20001/src/heap/heap-inl.h#newcode567 src/heap/heap-inl.h:567: __allocation__ = FUNCTION_CALL; ...
5 years, 2 months ago (2015-09-28 16:07:50 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1370123002/diff/20001/src/heap/heap-inl.h File src/heap/heap-inl.h (right): https://codereview.chromium.org/1370123002/diff/20001/src/heap/heap-inl.h#newcode567 src/heap/heap-inl.h:567: __allocation__ = FUNCTION_CALL; \ On 2015/09/28 16:07:50, Michael Starzinger ...
5 years, 2 months ago (2015-09-28 16:11:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370123002/40001
5 years, 2 months ago (2015-09-28 16:12:08 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 18:07:13 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2786ceec1eb491494d24d29a59eefbe3b6704be2 Cr-Commit-Position: refs/heads/master@{#30984}
5 years, 2 months ago (2015-09-28 18:07:40 UTC) #9
Benedikt Meurer
5 years, 2 months ago (2015-09-29 04:39:33 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1379493003/ by bmeurer@chromium.org.

The reason for reverting is: Breaks arm64 nosnap simulator (bogus cctest?):
https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%....

Powered by Google App Engine
This is Rietveld 408576698