MEM_RESERVE regions are not accessible by ReadProcessMemory()

util/win/process_info_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 261 matching lines @@
 
   std::vector<CheckedRange<WinVMAddress, WinVMSize>> result =
       GetReadableRangesOfMemoryMap(CheckedRange<WinVMAddress, WinVMSize>(5, 10),
                                    memory_info);
 
   ASSERT_EQ(result.size(), 1u);
   EXPECT_EQ(10, result[0].base());
   EXPECT_EQ(5, result[0].size());
 }
 
+TEST(ProcessInfo, ReserveIsInaccessible) {
+  std::vector<ProcessInfo::MemoryInfo> memory_info;
+  MEMORY_BASIC_INFORMATION mbi = {0};
+
+  mbi.BaseAddress = 0;
+  mbi.RegionSize = 10;
+  mbi.State = MEM_RESERVE;
+  memory_info.push_back(ProcessInfo::MemoryInfo(mbi));
+
+  mbi.BaseAddress = reinterpret_cast<void*>(10);
+  mbi.RegionSize = 20;
+  mbi.State = MEM_COMMIT;
+  memory_info.push_back(ProcessInfo::MemoryInfo(mbi));
+
+  std::vector<CheckedRange<WinVMAddress, WinVMSize>> result =
+      GetReadableRangesOfMemoryMap(CheckedRange<WinVMAddress, WinVMSize>(5, 10),
+                                   memory_info);
+
+  ASSERT_EQ(result.size(), 1u);
+  EXPECT_EQ(10, result[0].base());
+  EXPECT_EQ(5, result[0].size());
+}
+
 TEST(ProcessInfo, AccessibleRangesCoalesced) {
   std::vector<ProcessInfo::MemoryInfo> memory_info;
   MEMORY_BASIC_INFORMATION mbi = {0};
 
   mbi.BaseAddress = 0;
   mbi.RegionSize = 10;
   mbi.State = MEM_FREE;
   memory_info.push_back(ProcessInfo::MemoryInfo(mbi));
 
   mbi.BaseAddress = reinterpret_cast<void*>(10);
   mbi.RegionSize = 2;
   mbi.State = MEM_COMMIT;
   memory_info.push_back(ProcessInfo::MemoryInfo(mbi));
 
   mbi.BaseAddress = reinterpret_cast<void*>(12);
   mbi.RegionSize = 5;
-  mbi.State = MEM_RESERVE;
+  mbi.State = MEM_COMMIT;
   memory_info.push_back(ProcessInfo::MemoryInfo(mbi));
 
   std::vector<CheckedRange<WinVMAddress, WinVMSize>> result =
       GetReadableRangesOfMemoryMap(CheckedRange<WinVMAddress, WinVMSize>(11, 4),
                                    memory_info);
 
   ASSERT_EQ(result.size(), 1u);
   EXPECT_EQ(11, result[0].base());
   EXPECT_EQ(4, result[0].size());
 }
@@ skipping 60 matching lines @@
           CheckedRange<WinVMAddress, WinVMSize>(15, 100), memory_info);
 
   ASSERT_EQ(result.size(), 1u);
   EXPECT_EQ(15, result[0].base());
   EXPECT_EQ(5, result[0].size());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad