Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1370013003: OOPIF: Clear old focused frame when focus moves to a cross-process frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove !frame()->page() check from WebLocalFrameImpl::clearFocus() Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 bool selectWordAroundCaret() override; 172 bool selectWordAroundCaret() override;
173 void selectRange(const WebPoint& base, const WebPoint& extent) override; 173 void selectRange(const WebPoint& base, const WebPoint& extent) override;
174 void selectRange(const WebRange&) override; 174 void selectRange(const WebRange&) override;
175 void moveRangeSelectionExtent(const WebPoint&) override; 175 void moveRangeSelectionExtent(const WebPoint&) override;
176 void moveRangeSelection(const WebPoint& base, const WebPoint& extent, WebFra me::TextGranularity = CharacterGranularity) override; 176 void moveRangeSelection(const WebPoint& base, const WebPoint& extent, WebFra me::TextGranularity = CharacterGranularity) override;
177 void moveCaretSelection(const WebPoint&) override; 177 void moveCaretSelection(const WebPoint&) override;
178 bool setEditableSelectionOffsets(int start, int end) override; 178 bool setEditableSelectionOffsets(int start, int end) override;
179 bool setCompositionFromExistingText(int compositionStart, int compositionEnd , const WebVector<WebCompositionUnderline>& underlines) override; 179 bool setCompositionFromExistingText(int compositionStart, int compositionEnd , const WebVector<WebCompositionUnderline>& underlines) override;
180 void extendSelectionAndDelete(int before, int after) override; 180 void extendSelectionAndDelete(int before, int after) override;
181 void setCaretVisible(bool) override; 181 void setCaretVisible(bool) override;
182 void clearFocus() override;
182 int printBegin(const WebPrintParams&, const WebNode& constrainToNode) overri de; 183 int printBegin(const WebPrintParams&, const WebNode& constrainToNode) overri de;
183 float printPage(int pageToPrint, WebCanvas*) override; 184 float printPage(int pageToPrint, WebCanvas*) override;
184 float getPrintPageShrink(int page) override; 185 float getPrintPageShrink(int page) override;
185 void printEnd() override; 186 void printEnd() override;
186 bool isPrintScalingDisabledForPlugin(const WebNode&) override; 187 bool isPrintScalingDisabledForPlugin(const WebNode&) override;
187 bool getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOptions*) override; 188 bool getPrintPresetOptionsForPlugin(const WebNode&, WebPrintPresetOptions*) override;
188 bool hasCustomPageSizeStyle(int pageIndex) override; 189 bool hasCustomPageSizeStyle(int pageIndex) override;
189 bool isPageBoxVisible(int pageIndex) override; 190 bool isPageBoxVisible(int pageIndex) override;
190 void pageSizeAndMarginsInPixels( 191 void pageSizeAndMarginsInPixels(
191 int pageIndex, 192 int pageIndex,
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 // cleared upon close(). 400 // cleared upon close().
400 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 401 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
401 #endif 402 #endif
402 }; 403 };
403 404
404 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 405 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
405 406
406 } // namespace blink 407 } // namespace blink
407 408
408 #endif 409 #endif
OLDNEW
« no previous file with comments | « content/test/data/page_with_input_field.html ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698