Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1369993002: [api] Make sure InterceptorInfo is always in a verifyable state. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Make sure InterceptorInfo is always in a verifyable state. This should fix the Threading1 flakiness that we see on the waterfall. R=jarin@chromium.org Committed: https://crrev.com/39114da1a76742395d1791e0691fe137f366779e Cr-Commit-Position: refs/heads/master@{#30967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/api.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-09-28 08:26:52 UTC) #1
Benedikt Meurer
Jaro: PTAL Michael, Michael: FYI
5 years, 2 months ago (2015-09-28 08:27:44 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-09-28 08:28:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369993002/1
5 years, 2 months ago (2015-09-28 08:36:40 UTC) #5
Michael Achenbach
\o/ if it does!
5 years, 2 months ago (2015-09-28 08:37:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 09:02:37 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 09:02:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39114da1a76742395d1791e0691fe137f366779e
Cr-Commit-Position: refs/heads/master@{#30967}

Powered by Google App Engine
This is Rietveld 408576698