Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1369963002: X87: Full code shouldn't embed the type feedback vector. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 2 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Full code shouldn't embed the type feedback vector. port c90c60ba2689fb524a1526503c9c87f534cf58fb (r30940) original commit message: Make sure to always reference it indirectly. This allows us to make the vector native-context dependent should we wish. BUG= Committed: https://crrev.com/bac284ee75c80be60cf0c41a144e7ff71e1e922b Cr-Commit-Position: refs/heads/master@{#30954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +5 lines, -13 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 2 months ago (2015-09-28 02:33:15 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-09-28 02:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369963002/1
5 years, 2 months ago (2015-09-28 02:44:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 03:09:07 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 03:09:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bac284ee75c80be60cf0c41a144e7ff71e1e922b
Cr-Commit-Position: refs/heads/master@{#30954}

Powered by Google App Engine
This is Rietveld 408576698