Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1369923003: Add overrides to SkAndroidSDKCanvas, update SkHwuiRenderer (Closed)

Created:
5 years, 2 months ago by tomhudson
Modified:
5 years, 2 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add overrides to SkAndroidSDKCanvas, update SkHwuiRenderer We can not call android::uirenderer::DisplayListCanvas::reset() after the object has been constructed (due to an assert), so remove that call. Add two missing overrides to SkAndroidSDKCanvas: onDrawAtlas() and onDrawImageNine(). BUG=skia:4216 R=djsollen@google.com patch from issue 1377533003 at patchset 20001 (http://crrev.com/1377533003#ps20001) Committed: https://skia.googlesource.com/skia/+/458633496cda2714f175a71e0500335b3681ff16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M src/utils/android/SkAndroidSDKCanvas.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/utils/android/SkAndroidSDKCanvas.cpp View 1 chunk +24 lines, -2 lines 0 comments Download
M src/utils/android/SkHwuiRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369923003/1
5 years, 2 months ago (2015-09-30 21:01:02 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-09-30 21:01:03 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 2 months ago (2015-10-01 03:01:07 UTC) #5
scroggo
On 2015/10/01 03:01:07, commit-bot: I haz the power wrote: > No LGTM from a valid ...
5 years, 2 months ago (2015-10-01 14:54:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369923003/1
5 years, 2 months ago (2015-10-01 15:01:18 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 15:02:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/458633496cda2714f175a71e0500335b3681ff16

Powered by Google App Engine
This is Rietveld 408576698