Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1369913002: Fix DCHECK in ScopeInfo::Print(). (Closed)

Created:
5 years, 2 months ago by bnoordhuis
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix DCHECK in ScopeInfo::Print(). Committed: https://crrev.com/e874579f281ec200273aac90cba438e9ec0403bf Cr-Commit-Position: refs/heads/master@{#30978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/scopeinfo.cc View 1 chunk +9 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bnoordhuis
5 years, 2 months ago (2015-09-26 13:45:57 UTC) #2
Michael Achenbach
Please find a code owner. If you found my name with git blame, it's probably ...
5 years, 2 months ago (2015-09-28 08:47:34 UTC) #3
bnoordhuis
On 2015/09/28 08:47:34, Michael Achenbach wrote: > Please find a code owner. If you found ...
5 years, 2 months ago (2015-09-28 13:38:18 UTC) #5
rossberg
lgtm
5 years, 2 months ago (2015-09-28 13:41:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369913002/1
5 years, 2 months ago (2015-09-28 13:48:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 14:12:41 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 14:13:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e874579f281ec200273aac90cba438e9ec0403bf
Cr-Commit-Position: refs/heads/master@{#30978}

Powered by Google App Engine
This is Rietveld 408576698