Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1369903002: Android Chromoting: Add hooks for the official account-switcher (Closed)

Created:
5 years, 2 months ago by Lambros
Modified:
5 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android Chromoting: Add hooks for the official account-switcher This adds some GYP variables to allow official builds to modify the remoting_apk target. Also adds a destroy() method to the interface, to release resources used by the account-switcher. Also adds hooks to allow the account-switcher to gracefully handle connection errors to Google Play Services. BUG=517688 Committed: https://crrev.com/f3ffeee66a9abc6bf99860430d81c8396cc8e763 Cr-Commit-Position: refs/heads/master@{#351693}

Patch Set 1 #

Patch Set 2 : Add hooks for Google Play Services connection errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/accountswitcher/AccountSwitcher.java View 1 2 chunks +13 lines, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/accountswitcher/AccountSwitcherBasic.java View 1 2 chunks +9 lines, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/accountswitcher/AccountSwitcherFactory.java View 1 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/remoting_android.gypi View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lambros
5 years, 2 months ago (2015-09-26 05:19:50 UTC) #2
Sergey Ulanov
lgtm
5 years, 2 months ago (2015-09-28 19:14:51 UTC) #3
Lambros
PTAL, added more hooks.
5 years, 2 months ago (2015-09-29 18:28:17 UTC) #4
Sergey Ulanov
lgtm
5 years, 2 months ago (2015-10-01 00:28:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369903002/20001
5 years, 2 months ago (2015-10-01 00:32:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 01:09:49 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 01:10:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3ffeee66a9abc6bf99860430d81c8396cc8e763
Cr-Commit-Position: refs/heads/master@{#351693}

Powered by Google App Engine
This is Rietveld 408576698