include/core/SkError.h - Issue 13699004: first draft of error checking / reporting API

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/core/SkError.h

Issue 13699004: first draft of error checking / reporting API (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Several cleanups from Leon Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2013 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef SkError_DEFINED

	9 #define SkError_DEFINED

	10

	11 typedef enum {
	reed1 2013/04/08 19:47:31 I think all of our other enums are just enum SkEr I think all of our other enums are just enum SkError { ... }; reed1 2013/04/08 19:47:31 Skia's other enums are named in reverse order from Skia's other enums are named in reverse order from these. e.g. kNone_SkError, kInvalidArgument_SkError, ... humper 2013/04/08 20:10:55 Okay, I'll turn these around. On 2013/04/08 19:47 Okay, I'll turn these around. On 2013/04/08 19:47:31, reed1 wrote: Show quoted text > Skia's other enums are named in reverse order from these. > > e.g. > > kNone_SkError, > kInvalidArgument_SkError, > ...
	12 kError_NoError=0,

	13 kError_InvalidArgument,

	14 kError_InvalidOperation,

	15 kError_InvalidHandle,
	reed1 2013/04/08 19:47:31 What is a 'Handle' in the Skia world? What is a 'Handle' in the Skia world? humper 2013/04/08 20:10:55 Done. Show quoted text On 2013/04/08 19:47:31, reed1 wrote: > What is a 'Handle' in the Skia world? Done.
	16 kError_InvalidPaint,
	reed1 2013/04/08 19:47:31 What is an invalid paint? What is an invalid paint?
	17 kError_OutOfMemory,

	18 kError_ParseError

	19 } SkError;

	20

	21 SkError SkGetLastError();
	reed1 2013/04/08 19:47:31 Need some dox for each of these, including that th Need some dox for each of these, including that they are per-thread. humper 2013/04/08 20:10:55 Done. Show quoted text On 2013/04/08 19:47:31, reed1 wrote: > Need some dox for each of these, including that they are per-thread. Done.
	22 void SkClearLastError();

	23 typedef void (SkErrorCallbackFunction)(SkError, void );

	24

	25 void SkSetErrorCallback(SkErrorCallbackFunction cb, void *context);

	26 const char *SkGetLastErrorString();

	27

	28 #endif /* SkError_DEFINED */

OLD	NEW

« no previous file with comments | « gyp/tests.gyp ('k') | src/core/SkError.cpp » ('j') | no next file with comments »