ui/views/bubble/bubble_delegate.cc - Issue 13699002: add HideAndClose in preference to having Close sometimes magically defer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_delegate.cc

Issue 13699002: add HideAndClose in preference to having Close sometimes magically defer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: non aura Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | ui/views/widget/desktop_aura/desktop_native_widget_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/bubble/bubble_delegate.cc

diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc

index abfa8a5375605971e352a65e96dbf9f8ea651eff..807fcd58038feee6b1624ffafb5df31a8229ed13 100644

--- a/ui/views/bubble/bubble_delegate.cc

+++ b/ui/views/bubble/bubble_delegate.cc

@@ -221,7 +221,7 @@ void BubbleDelegateView::OnWidgetVisibilityChanged(Widget* widget,

void BubbleDelegateView::OnWidgetActivationChanged(Widget* widget,

bool active) {

if (close_on_deactivate() && widget == GetWidget() && !active)

- GetWidget()->Close();

+ GetWidget()->HideAndClose();

}

void BubbleDelegateView::OnWidgetBoundsChanged(Widget* widget,