Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: minidump/minidump_file_writer.cc

Issue 1369823002: Better location for adding ExtraMemory snapshots (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_file_writer.cc
diff --git a/minidump/minidump_file_writer.cc b/minidump/minidump_file_writer.cc
index 33c4806c8d2296aa59f244f0dd83bfd114f7c620..f0c8d4b87f155b60f423619d72193d2a9729548f 100644
--- a/minidump/minidump_file_writer.cc
+++ b/minidump/minidump_file_writer.cc
@@ -93,14 +93,14 @@ void MinidumpFileWriter::InitializeFromSnapshot(
auto crashpad_info = make_scoped_ptr(new MinidumpCrashpadInfoWriter());
crashpad_info->InitializeFromSnapshot(process_snapshot);
- memory_list->AddFromSnapshot(process_snapshot->ExtraMemory());
-
// Since the MinidumpCrashpadInfo stream is an extension, it’s safe to not add
// it to the minidump file if it wouldn’t carry any useful information.
if (crashpad_info->IsUseful()) {
AddStream(crashpad_info.Pass());
}
+ memory_list->AddFromSnapshot(process_snapshot->ExtraMemory());
+
AddStream(memory_list.Pass());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698