Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1369763002: Fix media element time display for times over an hour. (Closed)

Created:
5 years, 2 months ago by liberato (no reviews please)
Modified:
5 years, 2 months ago
CC:
blink-reviews, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix media element time display for times over an hour. Moves a misplaced modulo so that hours can become nonzero when constructing the time and duration strings for HTMLMediaElement. Also added a unit test for it. This is the post-merge version of https://codereview.chromium.org/1360203002/ BUG=535046 Committed: https://crrev.com/4025bad149997db1a957651f63e3b82389c23d1c Cr-Commit-Position: refs/heads/master@{#351055}

Patch Set 1 #

Total comments: 1

Patch Set 2 : iterators ftw. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp View 1 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
liberato (no reviews please)
this is the post-blink-merge version of https://codereview.chromium.org/1360203002/ PS4. thanks -fl
5 years, 2 months ago (2015-09-25 16:25:59 UTC) #2
DaleCurtis
lgtm % for() fix. https://codereview.chromium.org/1369763002/diff/1/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp File third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp (right): https://codereview.chromium.org/1369763002/diff/1/third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp#newcode132 third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp:132: for (unsigned i = 0; ...
5 years, 2 months ago (2015-09-25 17:40:04 UTC) #4
philipj_slow
lgtm
5 years, 2 months ago (2015-09-28 08:55:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369763002/20001
5 years, 2 months ago (2015-09-28 08:56:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 11:17:59 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 11:18:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4025bad149997db1a957651f63e3b82389c23d1c
Cr-Commit-Position: refs/heads/master@{#351055}

Powered by Google App Engine
This is Rietveld 408576698