Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 1369743003: Add a line number filter for layout tests. Suppress/fix Dartium layout tests. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/dart/microtask-queue-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
index 0a7483069b96b5f3568cb78f0a41e03129b089d9..1dfe1c4bfe6329abf81e0badd70d69f08e2385f6 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
@@ -311,6 +311,10 @@ class SingleTestRunner(object):
_observatory_cleaner = re.compile(r"^Observatory.*\n", re.MULTILINE)
_console_observatory_cleaner = re.compile(r"^CONSOLE INFO: Observatory.*\n", re.MULTILINE)
+ _line_number_cleaner = re.compile(r"\(dart:(\w+):\d+\)", re.MULTILINE)
+
+ def _line_number_substitution(self, match):
+ return "(dart:" + match.group(1) + ":xxxx)"
def _get_normalized_output_text(self, output):
"""Returns the normalized text output, i.e. the output in which
@@ -322,6 +326,7 @@ class SingleTestRunner(object):
normalized_lines = output.replace("\r\r\n", "\r\n").replace("\r\n", "\n")
normalized_lines = re.sub(self._observatory_cleaner, r"", normalized_lines)
normalized_lines = re.sub(self._console_observatory_cleaner, r"", normalized_lines)
+ normalized_lines = re.sub(self._line_number_cleaner, self._line_number_substitution, normalized_lines)
return normalized_lines
# FIXME: This function also creates the image diff. Maybe that work should
« no previous file with comments | « LayoutTests/dart/microtask-queue-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698