Do not hash default and communications media device ID

content/browser/renderer_host/media/audio_renderer_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/audio_renderer_host.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
@@ skipping 64 matching lines @@
                         std::make_pair(authorized, device_unique_id));
 }
 
 GURL ConvertToGURL(const url::Origin& origin) {
   return origin.unique() ? GURL() : GURL(origin.Serialize());
 }
 
 bool IsValidDeviceId(const std::string& device_id) {
   static const std::string::size_type kValidLength = 64;
 
-  if (device_id.empty())
+  if (device_id.empty() ||
+      device_id == media::AudioManagerBase::kDefaultDeviceId ||
+      device_id == media::AudioManagerBase::kCommunicationsDeviceId) {

[ajm, 2015/09/28 22:47:18]

Does it matter that ChromeOS is not using these IDs when a mic array is
available? See line 42-43:
https://codereview.chromium.org/1362093002/diff/140001/media/audio/cras/audio...

[Guido Urdaneta, 2015/09/29 10:36:12]

No, it does not matter. This is a check for hashed device IDs coming from the
renderer.
Those special IDs in ChromeOS will come hashed as an hex string from the
renderer just like nondefault IDs.

[tommi (sloooow) - chröme, 2015/09/29 11:59:51]

Is it using any other "known-and-not-translated" ID?
If it's only using hashed IDs, then I don't think it makes a difference.

[ajm, 2015/09/29 16:00:55]

Great, thanks.

[ajm, 2015/09/29 16:00:55]

No.

     return true;
+  }
 
   if (device_id.length() != kValidLength)
     return false;
 
   for (const char& c : device_id) {
     if ((c < 'a' || c > 'f') && (c < '0' || c > '9'))
       return false;
   }
 
   return true;
@@ skipping 798 matching lines @@
   callback.Run(success, *new_info);
 }
 
 bool AudioRendererHost::IsAuthorizationStarted(int stream_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   const auto& i = authorizations_.find(stream_id);
   return i != authorizations_.end();
 }
 
 }  // namespace content