Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: chrome/browser/webdata/web_data_service_factory.cc

Issue 13697002: Make autofill's Address store country using the country code so that app locale isn't needed for th… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix remaining tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/webdata/web_data_service_factory.h" 5 #include "chrome/browser/webdata/web_data_service_factory.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/profiles/profile_dependency_manager.h" 10 #include "chrome/browser/profiles/profile_dependency_manager.h"
10 #include "chrome/browser/ui/profile_error_dialog.h" 11 #include "chrome/browser/ui/profile_error_dialog.h"
11 #include "chrome/browser/webdata/autocomplete_syncable_service.h" 12 #include "chrome/browser/webdata/autocomplete_syncable_service.h"
12 #include "chrome/browser/webdata/autofill_profile_syncable_service.h" 13 #include "chrome/browser/webdata/autofill_profile_syncable_service.h"
13 #include "chrome/browser/webdata/keyword_table.h" 14 #include "chrome/browser/webdata/keyword_table.h"
14 #include "chrome/browser/webdata/logins_table.h" 15 #include "chrome/browser/webdata/logins_table.h"
15 #include "chrome/browser/webdata/token_service_table.h" 16 #include "chrome/browser/webdata/token_service_table.h"
16 #include "chrome/browser/webdata/web_apps_table.h" 17 #include "chrome/browser/webdata/web_apps_table.h"
17 #include "chrome/browser/webdata/web_data_service.h" 18 #include "chrome/browser/webdata/web_data_service.h"
18 #include "chrome/browser/webdata/web_intents_table.h" 19 #include "chrome/browser/webdata/web_intents_table.h"
(...skipping 10 matching lines...) Expand all
29 namespace { 30 namespace {
30 31
31 // Callback to show error dialog on profile load error. 32 // Callback to show error dialog on profile load error.
32 void ProfileErrorCallback(sql::InitStatus status) { 33 void ProfileErrorCallback(sql::InitStatus status) {
33 ShowProfileErrorDialog( 34 ShowProfileErrorDialog(
34 (status == sql::INIT_FAILURE) ? 35 (status == sql::INIT_FAILURE) ?
35 IDS_COULDNT_OPEN_PROFILE_ERROR : IDS_PROFILE_TOO_NEW_ERROR); 36 IDS_COULDNT_OPEN_PROFILE_ERROR : IDS_PROFILE_TOO_NEW_ERROR);
36 } 37 }
37 38
38 void InitSyncableServicesOnDBThread( 39 void InitSyncableServicesOnDBThread(
39 scoped_refptr<AutofillWebDataService> autofill_web_data) { 40 scoped_refptr<AutofillWebDataService> autofill_web_data,
41 const std::string& app_locale) {
40 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB)); 42 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::DB));
41 43
42 // Currently only Autocomplete and Autofill profiles use the new Sync API, but 44 // Currently only Autocomplete and Autofill profiles use the new Sync API, but
43 // all the database data should migrate to this API over time. 45 // all the database data should migrate to this API over time.
44 AutocompleteSyncableService::CreateForWebDataService(autofill_web_data); 46 AutocompleteSyncableService::CreateForWebDataService(autofill_web_data);
45 AutofillProfileSyncableService::CreateForWebDataService(autofill_web_data); 47 AutofillProfileSyncableService::CreateForWebDataService(
48 autofill_web_data, app_locale);
46 } 49 }
47 50
48 } // namespace 51 } // namespace
49 52
50 WebDataServiceWrapper::WebDataServiceWrapper() {} 53 WebDataServiceWrapper::WebDataServiceWrapper() {}
51 54
52 WebDataServiceWrapper::WebDataServiceWrapper(Profile* profile) { 55 WebDataServiceWrapper::WebDataServiceWrapper(Profile* profile) {
53 base::FilePath path = profile->GetPath(); 56 base::FilePath path = profile->GetPath();
54 path = path.Append(kWebDataFilename); 57 path = path.Append(kWebDataFilename);
55 58
(...skipping 24 matching lines...) Expand all
80 web_database_->LoadDatabase(WebDatabaseService::InitCallback()); 83 web_database_->LoadDatabase(WebDatabaseService::InitCallback());
81 84
82 autofill_web_data_ = new AutofillWebDataService( 85 autofill_web_data_ = new AutofillWebDataService(
83 web_database_, base::Bind(&ProfileErrorCallback)); 86 web_database_, base::Bind(&ProfileErrorCallback));
84 autofill_web_data_->Init(); 87 autofill_web_data_->Init();
85 88
86 web_data_ = new WebDataService( 89 web_data_ = new WebDataService(
87 web_database_, base::Bind(&ProfileErrorCallback)); 90 web_database_, base::Bind(&ProfileErrorCallback));
88 web_data_->Init(); 91 web_data_->Init();
89 92
90 BrowserThread::PostTask(BrowserThread::DB, FROM_HERE, 93 BrowserThread::PostTask(
91 base::Bind(&InitSyncableServicesOnDBThread, 94 BrowserThread::DB, FROM_HERE,
92 autofill_web_data_)); 95 base::Bind(&InitSyncableServicesOnDBThread,
96 autofill_web_data_,
97 g_browser_process->GetApplicationLocale()));
93 } 98 }
94 99
95 WebDataServiceWrapper::~WebDataServiceWrapper() { 100 WebDataServiceWrapper::~WebDataServiceWrapper() {
96 } 101 }
97 102
98 void WebDataServiceWrapper::Shutdown() { 103 void WebDataServiceWrapper::Shutdown() {
99 autofill_web_data_->ShutdownOnUIThread(); 104 autofill_web_data_->ShutdownOnUIThread();
100 web_data_->ShutdownOnUIThread(); 105 web_data_->ShutdownOnUIThread();
101 web_database_->ShutdownDatabase(); 106 web_database_->ShutdownDatabase();
102 } 107 }
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 } 185 }
181 186
182 ProfileKeyedService* 187 ProfileKeyedService*
183 WebDataServiceFactory::BuildServiceInstanceFor(Profile* profile) const { 188 WebDataServiceFactory::BuildServiceInstanceFor(Profile* profile) const {
184 return new WebDataServiceWrapper(profile); 189 return new WebDataServiceWrapper(profile);
185 } 190 }
186 191
187 bool WebDataServiceFactory::ServiceIsNULLWhileTesting() const { 192 bool WebDataServiceFactory::ServiceIsNULLWhileTesting() const {
188 return true; 193 return true;
189 } 194 }
OLDNEW
« no previous file with comments | « chrome/browser/webdata/autofill_profile_syncable_service.cc ('k') | chrome/browser/webdata/web_database_migration_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698