Make autofill's Address store country using the country code so that app locale isn't needed for th…

components/autofill/browser/field_types.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_BROWSER_FIELD_TYPES_H_
 #define COMPONENTS_AUTOFILL_BROWSER_FIELD_TYPES_H_
 
 #include <set>
 #include <string>
 
@@ skipping 44 matching lines @@
   ADDRESS_HOME_CITY = 33,
   ADDRESS_HOME_STATE = 34,
   ADDRESS_HOME_ZIP = 35,
   ADDRESS_HOME_COUNTRY = 36,
   ADDRESS_BILLING_LINE1 = 37,
   ADDRESS_BILLING_LINE2 = 38,
   ADDRESS_BILLING_APT_NUM = 39,
   ADDRESS_BILLING_CITY = 40,
   ADDRESS_BILLING_STATE = 41,
   ADDRESS_BILLING_ZIP = 42,
-  ADDRESS_BILLING_COUNTRY = 43,
+  ADDRESS_BILLING_COUNTRY = 43,  // This is the 2-letter country code.

[Ilya Sherman, 2013/04/05 05:18:01]

This annotation is not accurate.  We will now always *store* countries as their
2-letter country codes, but the field type covers spelled-out names as well.

I'd suggest moving this annotation to describe the field country_code_ in
address.cc.

[jam, 2013/04/05 06:45:54]

ah, you're right. removed.
the variable there is pretty well-named, so i think a comment would be redundant

 
   // ADDRESS_SHIPPING values [44,50] are deprecated.
 
   CREDIT_CARD_NAME = 51,
   CREDIT_CARD_NUMBER = 52,
   CREDIT_CARD_EXP_MONTH = 53,
   CREDIT_CARD_EXP_2_DIGIT_YEAR = 54,
   CREDIT_CARD_EXP_4_DIGIT_YEAR = 55,
   CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR = 56,
   CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR = 57,
   CREDIT_CARD_TYPE = 58,
   CREDIT_CARD_VERIFICATION_CODE = 59,
 
   COMPANY_NAME = 60,
 
   // Generic type whose default value is known.
   FIELD_WITH_DEFAULT_VALUE = 61,
 
   // No new types can be added.
 
   MAX_VALID_FIELD_TYPE = 62,
 };
 
 typedef std::set<AutofillFieldType> FieldTypeSet;
 
 #endif  // COMPONENTS_AUTOFILL_BROWSER_FIELD_TYPES_H_