Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1369683003: Oilpan: revert page navigation count GCing. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: revert page navigation count GCing. The inclusion of https://codereview.chromium.org/1353283002 as part of r350775 was not intentional - back it out. We want to land some variation of this now, but not in this form. R=haraken BUG=534524 Committed: https://crrev.com/d9e8f44fe594dcd9c4e2378637e4bee567ff9ccb Cr-Commit-Position: refs/heads/master@{#350806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369683003/1
5 years, 2 months ago (2015-09-25 09:56:12 UTC) #2
sof
please take a look. My apologies, landing this part shouldn't have happened.
5 years, 2 months ago (2015-09-25 09:57:22 UTC) #4
haraken
LGTM
5 years, 2 months ago (2015-09-25 09:59:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-25 11:26:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369683003/1
5 years, 2 months ago (2015-09-25 11:34:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 11:39:16 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 11:40:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9e8f44fe594dcd9c4e2378637e4bee567ff9ccb
Cr-Commit-Position: refs/heads/master@{#350806}

Powered by Google App Engine
This is Rietveld 408576698