Android Chromoting: Tint menu icons.

Android Chromoting: Tint menu icons.

Tints all action-bar menu icons so they are the same color as the
system icons (home/up button and three-dots overflow icon).

Committed: https://crrev.com/4b1a300f3e187c11bc5431be096da8ddb6a4d37c
Cr-Commit-Position: refs/heads/master@{#351175}

[Lambros, 2015-09-25 01:43:23]

lambroslambrou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2015-09-28 21:30:11]

It looks wrong that we have to do this manually (e.g. ActionBar doesn't apply
tint automatically) and that there is no way to specify it in the resources, but
LGTM if there is no cleaner way to achieve the same effect.

[Lambros, 2015-09-28 21:52:11]

On 2015/09/28 21:30:11, Sergey Ulanov wrote:
> It looks wrong that we have to do this manually (e.g. ActionBar doesn't apply
> tint automatically) and that there is no way to specify it in the resources,
but
> LGTM if there is no cleaner way to achieve the same effect.

I don't know if the regular ActionBar applies tint, but we are using the
AppCompat
Toolbar class, which apparently doesn't do the tinting for us :(

There is the android:tint resource property (which needs to be applied to a
Drawable XML definition, not a plain bitmap image), and also Drawable.setTint().
But these were introduced in Android L.
In order to work with older releases, it seems simpler to do what I've done
(and also suggested by Internet searches).

[Lambros, 2015-09-28 21:52:36]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2015-09-28 21:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369653002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369653002/1

[commit-bot: I haz the power, 2015-09-28 22:38:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-28 22:39:32]

Patchset 1 (id:??) landed as
https://crrev.com/4b1a300f3e187c11bc5431be096da8ddb6a4d37c
Cr-Commit-Position: refs/heads/master@{#351175}