Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 136963004: fix leaks in SkConf (Closed)

Created:
6 years, 10 months ago by humper
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix leaks in SkConf These leaks were small and would only happen with non-default runtime configuration things set, but they were still leaks and they should be squished. Valgrind reported leaks pre-patch, and all the rtconf leaks are gone after patch. BUG=skia:1722 Committed: http://code.google.com/p/skia/source/detail?r=13269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M include/utils/SkRTConf.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkRTConf.cpp View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
humper
6 years, 10 months ago (2014-01-31 15:46:51 UTC) #1
reed1
lgtm
6 years, 10 months ago (2014-01-31 15:50:07 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 10 months ago (2014-01-31 16:29:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/136963004/1
6 years, 10 months ago (2014-01-31 16:29:25 UTC) #4
commit-bot: I haz the power
Change committed as 13269
6 years, 10 months ago (2014-01-31 17:32:08 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 17:32:12 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 17:32:14 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698