Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1369583002: Revert of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp (Closed)

Created:
5 years, 3 months ago by Cait (Slow)
Modified:
5 years, 3 months ago
Reviewers:
stgao, jbudorick, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, pkotwicz, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@incremental-script-dep
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp (patchset #4 id:60001 of https://codereview.chromium.org/1356873003/ ) Reason for revert: broke Android build (see other messages for details). Original issue's description: > CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp > > Added output_paths to md5_check.py since it cuts down on > force=os.path.exists() boilder-plate (plus places that were forgetting > it). It also improves the message printed when PRINT_MD5_DIFFS=1 is set. > > Added a wrapper in build_utils.py that automatically handles --depfile > and --stamp options, which further cuts down on boilerplate in the > clients. > > Removed colorama to eliminate circular dependency between build_utils > and md5_check. > > BUG=533442 > > Committed: https://crrev.com/dea0f30983bc18874ac8c49443fb5079d4c1b798 > Cr-Commit-Position: refs/heads/master@{#350599} TBR=jbudorick@chromium.org,stgao@chromium.org,agrieve@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=533442 Committed: https://crrev.com/1748d384c547136d059d413f5acbb1622ba548f0 Cr-Commit-Position: refs/heads/master@{#350626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -202 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gyp/dex.py View 2 chunks +68 lines, -83 lines 0 comments Download
M build/android/gyp/javac.py View 6 chunks +28 lines, -17 lines 0 comments Download
M build/android/gyp/proguard.py View 2 chunks +15 lines, -5 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 2 chunks +0 lines, -43 lines 0 comments Download
M build/android/gyp/util/md5_check.py View 4 chunks +24 lines, -38 lines 0 comments Download
M build/android/gyp/util/md5_check_test.py View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cait (Slow)
Created Revert of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp
5 years, 3 months ago (2015-09-24 19:37:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369583002/1
5 years, 3 months ago (2015-09-24 19:39:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 19:50:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1748d384c547136d059d413f5acbb1622ba548f0 Cr-Commit-Position: refs/heads/master@{#350626}
5 years, 3 months ago (2015-09-24 19:51:17 UTC) #4
agrieve
5 years, 3 months ago (2015-09-24 20:04:55 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1369593002/ by agrieve@chromium.org.

The reason for reverting is: Fixed import path and ensured "ninja all" builds
locally..

Powered by Google App Engine
This is Rietveld 408576698