Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 1369573004: Move JS calls out of Dartium code (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index ba060bb2db26880bb0c1f5544dc7f9a2536809c7..15d17c07aa21f4005c533b22a95a2203c5b06c0b 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -13350,6 +13350,11 @@ class Element extends Node implements GlobalEventHandlers, ParentNode, ChildNode
})(#)''', element);
}
+ /// A secondary check for corruption, needed on IE
+ static bool _hasCorruptedAttributesAdditionalCheck(Element element) {
+ return JS('bool', r'!(#.attributes instanceof NamedNodeMap)', element);
+ }
+
static String _safeTagName(element) {
String result = 'element tag unavailable';
try {
@@ -40914,11 +40919,12 @@ class _ValidatingTreeSanitizer implements NodeTreeSanitizer {
// If getting/indexing attributes throws, count that as corrupt.
attrs = element.attributes;
isAttr = attrs['is'];
+ var corruptedTest1 = Element._hasCorruptedAttributes(element);
+
// On IE, erratically, the hasCorruptedAttributes test can return false,
// even though it clearly is corrupted. A separate copy of the test
// inlining just the basic check seems to help.
- var corruptedTest1 = Element._hasCorruptedAttributes(element);
- var corruptedTest2 = JS('bool', r'!(#.attributes instanceof NamedNodeMap)', element);
+ var corruptedTest2 = Element._hasCorruptedAttributesAdditionalCheck(element);
corrupted = corruptedTest1 || corruptedTest2;
} catch(e) {}
var elementText = 'element unprintable';
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698