Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: pkg/analyzer/test/source/analysis_options_provider_test.dart

Issue 1369573003: Fix handling of empty .analysis_options files and test this case (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.source.analysis_options_provider; 5 library test.source.analysis_options_provider;
6 6
7 import 'package:analyzer/file_system/memory_file_system.dart'; 7 import 'package:analyzer/file_system/memory_file_system.dart';
8 import 'package:analyzer/source/analysis_options_provider.dart'; 8 import 'package:analyzer/source/analysis_options_provider.dart';
9 import 'package:unittest/unittest.dart'; 9 import 'package:unittest/unittest.dart';
10 import 'package:yaml/yaml.dart'; 10 import 'package:yaml/yaml.dart';
(...skipping 23 matching lines...) Expand all
34 expect(ignore[0], equals('ignoreme.dart')); 34 expect(ignore[0], equals('ignoreme.dart'));
35 expect(ignore[1], equals('sdk_ext/**')); 35 expect(ignore[1], equals('sdk_ext/**'));
36 }); 36 });
37 test('test_doesnotexist', () { 37 test('test_doesnotexist', () {
38 var optionsProvider = new AnalysisOptionsProvider(); 38 var optionsProvider = new AnalysisOptionsProvider();
39 Map<String, YamlNode> options = 39 Map<String, YamlNode> options =
40 optionsProvider.getOptions(resourceProvider.getFolder('/empty')); 40 optionsProvider.getOptions(resourceProvider.getFolder('/empty'));
41 expect(options.length, equals(0)); 41 expect(options.length, equals(0));
42 }); 42 });
43 }); 43 });
44 group('AnalysisOptionsProviderEmpty', () {
45 setUp(() {
46 buildResourceProvider(true);
47 });
48 tearDown(() {
49 clearResourceProvider();
50 });
51 test('test_simple', () {
52 var optionsProvider = new AnalysisOptionsProvider();
53 Map<String, YamlNode> options =
54 optionsProvider.getOptions(resourceProvider.getFolder('/'));
55 });
56 });
44 } 57 }
45 58
46 MemoryResourceProvider resourceProvider; 59 MemoryResourceProvider resourceProvider;
47 60
48 buildResourceProvider() { 61 buildResourceProvider([bool emptyAnalysisOptions = false]) {
49 resourceProvider = new MemoryResourceProvider(); 62 resourceProvider = new MemoryResourceProvider();
50 resourceProvider.newFolder('/empty'); 63 resourceProvider.newFolder('/empty');
51 resourceProvider.newFolder('/tmp'); 64 resourceProvider.newFolder('/tmp');
52 resourceProvider.newFile( 65 if (emptyAnalysisOptions) {
66 resourceProvider.newFile('/.analysis_options', r'''''');
67 } else {
68 resourceProvider.newFile(
53 '/.analysis_options', 69 '/.analysis_options',
54 r''' 70 r'''
55 analyzer: 71 analyzer:
56 ignore: 72 ignore:
57 - ignoreme.dart 73 - ignoreme.dart
58 - 'sdk_ext/**' 74 - 'sdk_ext/**'
59 '''); 75 ''');
76 }
77
60 } 78 }
61 79
62 clearResourceProvider() { 80 clearResourceProvider() {
63 resourceProvider = null; 81 resourceProvider = null;
64 } 82 }
65 83
66 emptyResourceProvider() { 84 emptyResourceProvider() {
67 resourceProvider = new MemoryResourceProvider(); 85 resourceProvider = new MemoryResourceProvider();
68 } 86 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698