Issue 1369443002: Revert "Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of https://codereview.chromium.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1369443002: Revert "Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of https://codereview.chromium.… (Closed)

Created:
5 years, 3 months ago by reed1

Modified:
5 years, 3 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "Revert of remove unused SkCachingPixelRef (patchset #1 id:1 of https://codereview.chromium.org/1364743002/ )" removed test for unsupported SkInstallDiscardable... This reverts commit 60c73d51808b9d78f65381b83f628a3f523042fe. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/dd42e5c05ce2f5e6da9a055544849dd8ae4e6733

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -197 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	src/lazy/SkCachingPixelRef.h	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	src/lazy/SkCachingPixelRef.cpp	View	1 chunk	+0 lines, -74 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	5 chunks	+9 lines, -52 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369443002/1

5 years, 3 months ago (2015-09-24 07:16:19 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-24 07:21:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd42e5c05ce2f5e6da9a055544849dd8ae4e6733

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages