Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1369413002: Revert of [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. (Closed)

Created:
5 years, 2 months ago by dgozman
Modified:
5 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. (patchset #1 id:1 of https://codereview.chromium.org/1360143003/ ) Reason for revert: This patch added a race. It should be using DidStartNavigationToPendingEntry instead. Original issue's description: > [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. > > DidStartProvisionalLoadForFrame is enough here. > > BUG=none > > Committed: https://crrev.com/ee6eca69ffbd1d510d02397df5047f27cc256e8e > Cr-Commit-Position: refs/heads/master@{#350974} TBR=pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/e1564e729873b9b2d875a70dec2a5f4d81952dd9 Cr-Commit-Position: refs/heads/master@{#351143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgozman
Created Revert of [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings.
5 years, 2 months ago (2015-09-28 20:54:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369413002/1
5 years, 2 months ago (2015-09-28 20:55:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:59:27 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:01:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1564e729873b9b2d875a70dec2a5f4d81952dd9
Cr-Commit-Position: refs/heads/master@{#351143}

Powered by Google App Engine
This is Rietveld 408576698