Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1369373002: Revert of Enable timerfd in libusb. (Closed)

Created:
5 years, 2 months ago by pavely
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable timerfd in libusb. (patchset #3 id:40001 of https://codereview.chromium.org/1368773005/ ) Reason for revert: Speculatively reverting change that might cause failures: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/4391 https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/42667 Original issue's description: > Enable timerfd in libusb. > > This compile flag enables correct timeout handling in libusb. > Without it, timeouts of e.g. interrupt transfers are ignored in most cases. > > BUG=535950 > > Committed: https://crrev.com/072a708b34caad4e046623c2a1c237dc751b92b9 > Cr-Commit-Position: refs/heads/master@{#351072} TBR=reillyg@chromium.org,pneubeck@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=535950 Committed: https://crrev.com/c35967d12137a49d9ec0cbab0571ea4c03c5ac57 Cr-Commit-Position: refs/heads/master@{#351090}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/libusb/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libusb/libusb.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pavely
Created Revert of Enable timerfd in libusb.
5 years, 2 months ago (2015-09-28 18:16:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369373002/1
5 years, 2 months ago (2015-09-28 18:20:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 18:24:29 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 18:25:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c35967d12137a49d9ec0cbab0571ea4c03c5ac57
Cr-Commit-Position: refs/heads/master@{#351090}

Powered by Google App Engine
This is Rietveld 408576698