Move font-size property handling into CSSPropertyParser

Move font-size property handling into CSSPropertyParser

Move font-size property handling from LegacyCSSPropertyParser into CSSPropertyParser.

This CL also addresses a view naming suggestions not implemented in 9ef67beb.

BUG=499780
Committed: https://crrev.com/f26fbfab0961ec2569807c142e552aeb88836888
Cr-Commit-Position: refs/heads/master@{#351708}

[rwlbuis, 2015-09-30 15:34:38]

rob.buis@samsung.com changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[rwlbuis, 2015-09-30 15:34:39]

PTAL.

[rwlbuis, 2015-09-30 17:05:15]

Patchset #4 (id:60001) has been deleted

[alancutter (OOO until 2018), 2015-09-30 23:55:38]

lgtm with nits.

The description title should mention CSSPropertyParser and font-size,
consumeLengthOrPercent is more of an implementation detail and doesn't have to
be in the title.

https://chromiumcodereview.appspot.com/1369353002/diff/80001/third_party/WebK...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://chromiumcodereview.appspot.com/1369353002/diff/80001/third_party/WebK...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:143: const
CSSCalcValue* value() const { return m_calcValue.get(); }
I wonder if peekValue() would be a more consistent name with the token range
interface.

https://chromiumcodereview.appspot.com/1369353002/diff/80001/third_party/WebK...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:236: }
if (calcParser.value() && calcParser.value()->category() == CalcLength)
    return calcParser.consumeValue();

https://chromiumcodereview.appspot.com/1369353002/diff/80001/third_party/WebK...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:254: return
calcParser.consumeValue();
The negated expression is a bit weird, perhaps unnegate and return
calcParser.consumeValue() instead, then you can fall through to the other return
nullptr.

[rwlbuis, 2015-10-01 00:40:51]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-10-01 00:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1369353002/#ps100001 (title: "Patch for
landing")

[commit-bot: I haz the power, 2015-10-01 00:42:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369353002/100001

[commit-bot: I haz the power, 2015-10-01 00:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 00:52:15]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rwlbuis, 2015-10-01 01:37:32]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-10-01 01:38:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369353002/100001

[commit-bot: I haz the power, 2015-10-01 02:25:46]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-10-01 02:26:45]

Patchset 5 (id:??) landed as
https://crrev.com/f26fbfab0961ec2569807c142e552aeb88836888
Cr-Commit-Position: refs/heads/master@{#351708}