Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1369343002: [cctest] adding --help option to output basic information about cctest (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cctest] adding --help option to output basic information about cctest [run-tests.py] - adding more detailed information about the flags - show more detailed error message on failing Popen commands BUG= Committed: https://crrev.com/eecf6cbd9735715a2fdc3579a75eb67849bfb733 Cr-Commit-Position: refs/heads/master@{#30997}

Patch Set 1 #

Total comments: 2

Patch Set 2 : extending help comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M test/cctest/cctest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 4 chunks +8 lines, -3 lines 0 comments Download
M tools/testrunner/local/commands.py View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Camillo Bruni
PTAL After spending again 15mins figureing out how to run cctest and run-tests.py I added ...
5 years, 2 months ago (2015-09-28 15:26:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369343002/1
5 years, 2 months ago (2015-09-28 15:26:23 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 15:26:25 UTC) #6
Michael Achenbach
lgtm https://codereview.chromium.org/1369343002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/1369343002/diff/1/tools/run-tests.py#newcode225 tools/run-tests.py:225: help="The test modes in which to run (comma-separated): ...
5 years, 2 months ago (2015-09-29 08:11:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369343002/20001
5 years, 2 months ago (2015-09-29 08:18:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 08:41:30 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eecf6cbd9735715a2fdc3579a75eb67849bfb733 Cr-Commit-Position: refs/heads/master@{#30997}
5 years, 2 months ago (2015-09-29 08:41:52 UTC) #12
Camillo Bruni
5 years, 2 months ago (2015-09-29 11:00:07 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1369343002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/1369343002/diff/1/tools/run-tests.py#newcode225
tools/run-tests.py:225: help="The test modes in which to run (comma-separated):
%s" % MODES.keys(),
On 2015/09/29 at 08:11:14, Michael Achenbach wrote:
> Here is a long-standing problem hiding. With buildbot or ninja, the modes are
with capitals, with make not.

Yeah I know, since I use the ninja setup locally :/ but at least with the file
not found warning you'll figure out quickly that probably you need uppercase.
I'll add a comment.

Powered by Google App Engine
This is Rietveld 408576698