Add retail logging for WebRTC IP permission debugability

Add retail logging for WebRTC IP permission debugability.

Also refactored a function which will be used later in test code. CHECK() was used to prevent the case if media_permission is null for any reason that we blindly grant the permission.

BUG=520101
Committed: https://crrev.com/5ffbdf627167c66c3337ee078ed866b344f0ba7f
Cr-Commit-Position: refs/heads/master@{#352090}

[guoweis_left_chromium, 2015-10-01 19:19:15]

guoweis@chromium.org changed reviewers:
+ sergeyu@chromium.org

[guoweis_left_chromium, 2015-10-01 19:19:16]

PTAL.

[Sergey Ulanov, 2015-10-01 23:19:24]

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:77: if
(render_frame) {
What are the cases when render_frame may be null here? Is it save to grant
permission to the list of networks in that case?

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:80:
CHECK(media_permission);
Does this need to be CHECK() and not DCHECK()?

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:490:
RenderViewImpl::FromWebView(web_frame->view());
This call is now duplicated in CreateMediaPermissionProxy().

[guoweis_left_chromium, 2015-10-02 04:33:20]

Only keep the logging now. PTAL.

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:77: if
(render_frame) {
On 2015/10/01 23:19:24, Sergey Ulanov wrote:
> What are the cases when render_frame may be null here? Is it save to grant
> permission to the list of networks in that case?

I don't think render_frame could be null. But to simplify this change, I removed
this code change.

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:80:
CHECK(media_permission);
On 2015/10/01 23:19:24, Sergey Ulanov wrote:
> Does this need to be CHECK() and not DCHECK()?

probably DCHECK is enough.

https://codereview.chromium.org/1369333007/diff/20001/content/renderer/media/...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:490:
RenderViewImpl::FromWebView(web_frame->view());
On 2015/10/01 23:19:24, Sergey Ulanov wrote:
> This call is now duplicated in CreateMediaPermissionProxy().

This is to get RenderViewImpl. The one in CreateMediaPermissionProxy is for
RenderFrameImpl. It's different.

[Sergey Ulanov, 2015-10-02 18:07:37]

lgtm

[guoweis2, 2015-10-02 18:14:13]

The CQ bit was checked by guoweis@google.com

[commit-bot: I haz the power, 2015-10-02 18:15:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369333007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369333007/40001

[commit-bot: I haz the power, 2015-10-02 18:48:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-02 18:48:54]

Patchset 3 (id:??) landed as
https://crrev.com/5ffbdf627167c66c3337ee078ed866b344f0ba7f
Cr-Commit-Position: refs/heads/master@{#352090}