Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1369333003: Subzero. Enable Atomics in ARM. (Closed)

Created:
5 years, 2 months ago by John
Modified:
5 years, 2 months ago
Reviewers:
Jim Stichnoth, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adds i64 register pairs. #

Patch Set 3 : Adds ldrex support. #

Patch Set 4 : Adds strex support. #

Patch Set 5 : Uses the more efficient ldr/str instructions when not dealing with i64. #

Patch Set 6 : Implements AtomicCmpxchg; Fixes a reg-aliasing related bug. #

Patch Set 7 : Isolates the lowering changes -- Everything else has been reviewed separately. #

Patch Set 8 : Isolates the lowering changes -- Everything else has been reviewed separately. #

Patch Set 9 : Comments; lit; undo's; final patch prior to review. #

Total comments: 8

Patch Set 10 : Addresses comments; make format; git pull; merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+959 lines, -40 lines) Patch
M Makefile.standalone View 1 chunk +0 lines, -1 line 0 comments Download
M crosstest/test_sync_atomic_main.cpp View 1 2 3 4 5 6 7 8 3 chunks +12 lines, -3 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 2 3 4 5 6 7 8 9 4 chunks +11 lines, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 4 5 6 7 8 9 17 chunks +497 lines, -32 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 2 3 4 5 6 7 8 63 chunks +439 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
John
5 years, 2 months ago (2015-10-05 19:28:37 UTC) #4
Jim Stichnoth
https://chromiumcodereview.appspot.com/1369333003/diff/200001/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (right): https://chromiumcodereview.appspot.com/1369333003/diff/200001/src/IceTargetLoweringARM32.cpp#newcode2592 src/IceTargetLoweringARM32.cpp:2592: // fake-use(addr, operand) @ prevents undesireable clobbering. undesirable https://chromiumcodereview.appspot.com/1369333003/diff/200001/src/IceTargetLoweringARM32.cpp#newcode2614 ...
5 years, 2 months ago (2015-10-05 22:07:06 UTC) #5
John
https://codereview.chromium.org/1369333003/diff/200001/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (right): https://codereview.chromium.org/1369333003/diff/200001/src/IceTargetLoweringARM32.cpp#newcode2592 src/IceTargetLoweringARM32.cpp:2592: // fake-use(addr, operand) @ prevents undesireable clobbering. On 2015/10/05 ...
5 years, 2 months ago (2015-10-06 12:03:38 UTC) #6
Jim Stichnoth
lgtm
5 years, 2 months ago (2015-10-06 13:07:41 UTC) #7
John
5 years, 2 months ago (2015-10-06 13:54:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #10 (id:220001) manually as
578f1161ad7a3ef98c90d88e5734940523d1f8e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698