Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369333002: Add cast and assignment operators to SkAtomic. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add cast and assignment operators to SkAtomic. This is not really an API change. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/0869267a7c6c58fb68a49b3c2e6d4f231d6645dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : add this and make operator= correct #

Patch Set 3 : remove atomic include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M include/core/SkAtomics.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
herb_g
5 years, 2 months ago (2015-09-28 15:07:15 UTC) #2
mtklein
lgtm with nits https://codereview.chromium.org/1369333002/diff/1/include/core/SkAtomics.h File include/core/SkAtomics.h (right): https://codereview.chromium.org/1369333002/diff/1/include/core/SkAtomics.h#newcode62 include/core/SkAtomics.h:62: return load(); this-> https://codereview.chromium.org/1369333002/diff/1/include/core/SkAtomics.h#newcode67 include/core/SkAtomics.h:67: store(v); ...
5 years, 2 months ago (2015-09-28 15:10:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369333002/1
5 years, 2 months ago (2015-09-28 15:10:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 15:16:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369333002/20001
5 years, 2 months ago (2015-09-28 15:39:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369333002/40001
5 years, 2 months ago (2015-09-28 15:42:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2894)
5 years, 2 months ago (2015-09-28 15:43:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369333002/40001
5 years, 2 months ago (2015-09-28 15:58:38 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 15:59:21 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0869267a7c6c58fb68a49b3c2e6d4f231d6645dc

Powered by Google App Engine
This is Rietveld 408576698