Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1369323002: Fix StartupBrowserCreatorTriggeredResetTest.TestTriggeredResetDoesNotShowWithFirstRunURLs (Closed)

Created:
5 years, 2 months ago by robertshield
Modified:
5 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix StartupBrowserCreatorTriggeredResetTest.TestTriggeredResetDoesNotShowWithFirstRunURLs in official builds. Expect the first tab to be the signin page during browser tests run for an official build. BUG=536730 TEST=browser_Tests.exe --gtest_filter=*StartupBrowserCreatorTriggeredResetTest* TBR=msw Committed: https://crrev.com/af50fda8b19e511c793e54a39c6fa2f7cbdd46d7 Cr-Commit-Position: refs/heads/master@{#351083}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc View 2 chunks +10 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (5 generated)
robertshield
This has broken tests on the official builder, so I'll land it now, CQ willing. ...
5 years, 2 months ago (2015-09-28 15:38:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369323002/20001
5 years, 2 months ago (2015-09-28 15:39:28 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 15:39:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369323002/20001
5 years, 2 months ago (2015-09-28 15:59:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-09-28 16:36:29 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/af50fda8b19e511c793e54a39c6fa2f7cbdd46d7 Cr-Commit-Position: refs/heads/master@{#351083}
5 years, 2 months ago (2015-09-28 16:37:50 UTC) #11
msw
5 years, 2 months ago (2015-09-28 18:19:43 UTC) #12
Message was sent while issue was closed.
lgtm with very optional nit

https://codereview.chromium.org/1369323002/diff/20001/chrome/browser/ui/start...
File
chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc
(right):

https://codereview.chromium.org/1369323002/diff/20001/chrome/browser/ui/start...
chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc:159:
EXPECT_EQ(signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false),
optional nit for optional follow up refactoring :)
  GURL expected_url = signin::ShouldShowPromoAtStartup(browser()->profile(),
true) ? signin::GetPromoURL(signin_metrics::SOURCE_START_PAGE, false) :
GURL(chrome::kChromeUINewTabURL);
  EXPECT_EQ(expected_url, tab_strip->GetWebContentsAt(0)->GetURL());

Powered by Google App Engine
This is Rietveld 408576698