Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1369313004: [turbofan] Make string comparisons effectful. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make string comparisons effectful. BUG=v8:4446 LOG=n Committed: https://crrev.com/904ac0ae2ca9dbdd159be6dc0707cea78ec8fcfa Cr-Commit-Position: refs/heads/master@{#31006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -41 lines) Patch
M src/compiler/js-typed-lowering.cc View 4 chunks +32 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +32 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +18 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 18 chunks +20 lines, -22 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 2 months ago (2015-09-29 14:07:44 UTC) #2
Benedikt Meurer
Awesome, thanks. LGTM
5 years, 2 months ago (2015-09-29 14:27:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369313004/1
5 years, 2 months ago (2015-09-29 14:37:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 14:39:01 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 14:39:10 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/904ac0ae2ca9dbdd159be6dc0707cea78ec8fcfa
Cr-Commit-Position: refs/heads/master@{#31006}

Powered by Google App Engine
This is Rietveld 408576698