Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: build/android/pylib/android_commands.py

Issue 13693002: [Android] Attempt to fix timeouts on Android bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/android_commands.py
diff --git a/build/android/pylib/android_commands.py b/build/android/pylib/android_commands.py
index 46bc3e44d0b039a45635841eea83babb84e83bd6..793667f8199b963680a016953c91cb0bdee598c7 100644
--- a/build/android/pylib/android_commands.py
+++ b/build/android/pylib/android_commands.py
@@ -682,10 +682,9 @@ class AndroidCommands(object):
self.RunShellCommand(self._util_wrapper + ' ' + MD5SUM_DEVICE_PATH +
' ' + device_path))
assert os.path.exists(local_path), 'Local path not found %s' % local_path
- hashes_on_host = _ComputeFileListHash(
- subprocess.Popen(
- '%s_host %s' % (self._md5sum_path, local_path),
- stdout=subprocess.PIPE, shell=True).stdout)
+ md5sum_output = cmd_helper.GetCmdOutput(
+ ['%s_host' % self._md5sum_path, local_path])
+ hashes_on_host = _ComputeFileListHash(md5sum_output)
if hashes_on_device == hashes_on_host:
return
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698